Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code generation service #1410

Closed
johanstokking opened this issue Oct 2, 2019 · 3 comments · Fixed by #1413
Closed

QR code generation service #1410

johanstokking opened this issue Oct 2, 2019 · 3 comments · Fixed by #1413
Assignees
Labels
blocking Another issue or pull request is waiting for this compat/api This could affect API compatibility in progress We're working on it
Milestone

Comments

@johanstokking
Copy link
Member

Summary

QR code generation service

Why do we need this?

To generate QR codes in one place instead of moving the responsibility to the clients.

See #1407 (comment)

What is already there? What do you see now?

#1392 is introducing an offline QR code generation in CLI. This is offline, but imports QR code formats and rendering in the CLI, which may run out of sync with the server version.

We have a pkg/qrcode with the necessary plumbing

What is missing? What do you want to see?

First class service for QR code generation and potentially parsing

It returns a list of formats for entities (i.e. EndDevice and Gateway), the required field mask and has an rpc for generating the QR code. It should be able to render it (png in requested size), return a bitmap ([][]bool) and/or text value.

How do you propose to implement this?

First class component, new gRPC service, start with EndDevice and generation of QR codes, but allow for Gateway and parsing QR codes too

Can you do this yourself and submit a Pull Request?

Yes

@johanstokking johanstokking added the compat/api This could affect API compatibility label Oct 2, 2019
@johanstokking johanstokking added this to the October 2019 milestone Oct 2, 2019
@johanstokking johanstokking self-assigned this Oct 2, 2019
@johanstokking johanstokking added the blocking Another issue or pull request is waiting for this label Oct 2, 2019
@johanstokking
Copy link
Member Author

Blocking #1407

@johanstokking
Copy link
Member Author

Blocking #1392

@johanstokking
Copy link
Member Author

Blocking #1209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Another issue or pull request is waiting for this compat/api This could affect API compatibility in progress We're working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant