Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nixpkgs expression #111

Open
rvolosatovs opened this issue Feb 7, 2019 · 5 comments
Open

Add Nixpkgs expression #111

rvolosatovs opened this issue Feb 7, 2019 · 5 comments

Comments

@rvolosatovs
Copy link
Contributor

Summary:

Package TTN stack and CLI for https://github.com/NixOS/nixpkgs
Adding a NixOS module for ease of deployment could be a nice next step.
References #86

Why do we need this?

To make users happy

What is already there? What do you see now?

Nothing

What is missing? What do you want to see?

Nixpkgs expression.

How do you propose to implement this?

Similar to https://github.com/NixOS/nixpkgs/blob/d499b7d821106964581cbb6eab5354fbdf7a6847/pkgs/development/tools/richgo/default.nix#L1-L21
We just need to set TTN_LW_HTTP_STATIC_SEARCH_PATH for stack in a wrapper, same as it's done for Brew in #109
We can use https://github.com/adisbladis/vgo2nix to generate most of the expression.(Note, however, that I had an issue with Thrift dependency when I tried to do that)

@rvolosatovs rvolosatovs added the ux label Feb 7, 2019
@rvolosatovs rvolosatovs added this to the Backlog milestone Feb 7, 2019
@rvolosatovs rvolosatovs self-assigned this Feb 7, 2019
@johanstokking johanstokking added documentation This involves writing user documentation and removed ux labels Feb 7, 2019
@htdvisser htdvisser added release and removed documentation This involves writing user documentation labels Oct 10, 2019
@htdvisser htdvisser added needs/triage We still need to triage this and removed release labels Mar 26, 2021
@htdvisser htdvisser removed this from the Backlog milestone Mar 26, 2021
@htdvisser
Copy link
Contributor

Is there any demand for this? Otherwise I think we should just close this.

@rvolosatovs
Copy link
Contributor Author

rvolosatovs commented Mar 26, 2021

This is something that needs to be done before the demand is there.

There's a big difference between a user just doing

nix run nixpkgs.lorawan-stack -c ttn-lw-stack start

and having stack running in their terminal window immediately and them going here and filing an issue, setting up Go and whatnot.

@rvolosatovs
Copy link
Contributor Author

rvolosatovs commented Mar 26, 2021

Additionally, if we want to encourage open-source developers to actually develop, I think we should reconsider adding Nix support to out project via shell.nix. @johanstokking I opened a PR before, but you rejected it (https://github.com/TheThingsIndustries/lorawan-stack/pull/256)

@johanstokking
Copy link
Member

and having stack running in their terminal window immediately and them going here and filing an issue, setting up Go and whatnot.

This would be useful for the CLI. The Stack isn't something you usually start from the terminal as a non-developer.

@johanstokking I open a PR before, but you rejected it

That was when we were just a few months in development with TTS, 1,5 year before our first release, so at the time it didn't make sense to spend time on that.

@htdvisser
Copy link
Contributor

As just discussed, we'll keep the issue open, but don't work on it unless it gets some upvotes.

@htdvisser htdvisser removed the needs/triage We still need to triage this label Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants