Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag descriptions #185

Open
mjamescompton opened this issue May 25, 2021 · 7 comments
Open

Add tag descriptions #185

mjamescompton opened this issue May 25, 2021 · 7 comments
Assignees
Labels
Milestone

Comments

@mjamescompton
Copy link
Contributor

mjamescompton commented May 25, 2021

Summary

Generate and include tag description

Why do we need this?

To improve SEO the tag landing pages need to have a description explaining them.

What is already there? What do you see now?

All Sensors, IPCode, Frequency plans have a tag page generated, if they are defined by a device.

What is missing? What do you want to see?

How do you propose to implement this?

@anastasiagramm Could you work on the content for the tags, I have generated a google sheet

https://docs.google.com/spreadsheets/d/1OC-bcU5a8ydJBKBt0QELO-MqzgA7nhoEoGSTFMZ4hvM/edit?usp=sharing

Can you fill in the descriptions here, there is a separate table for Sensors, IPCode, Frequency plans. I have included all the allowed fields from device schema

https://github.com/TheThingsNetwork/lorawan-devices/blob/master/lib/draft/schema.json

so they should all be there and we can add new tables if we include any new fields. A small warning I will not read the descriptions so please make sure they are correct in this doc.

Can you do this yourself and submit a Pull Request?

yes

@mjamescompton mjamescompton added this to the 2021 Q2 milestone May 25, 2021
@github-actions github-actions bot added the needs/triage We still need to triage this label May 25, 2021
@mjamescompton mjamescompton self-assigned this May 25, 2021
@nejraselimovic nejraselimovic removed the needs/triage We still need to triage this label May 25, 2021
@mjamescompton
Copy link
Contributor Author

@anastasiagramm I have also added a field at the bottom of each page for a general description of the tag category Sensors, IPCode, Frequency plans

@mjamescompton
Copy link
Contributor Author

I've added LoRaWan version and Regional Parameters and a few others which are less important, if you can start with the ones above first and LoRaWan version and Regional Parameters, ignore the others for now.

@johanstokking
Copy link
Member

  • Include tag description, either within the schema or this can be Hugo data @johanstokking what do you recommend?

We can't really put it in the schema because JSON schema doesn't support descriptions for enum values.

I think that a data file would be helpful. I'm okay with checking that in at https://github.com/lorawan-schema/draft-devices. It can be validated against the schema.

{
  "sensors": {
    "temperature": {
      "description": "Temperature"
    },
    ...
  },
  "ipCodes": {
    "IP68": ...
  },
  ...
}

@anastasiagramm
Copy link

@mjamescompton I've filled in the descriptions that you mentioned. please let me know when you need the other ones

@mjamescompton
Copy link
Contributor Author

mjamescompton commented Jun 9, 2021

@laurensslats Can you review the descriptions

My feedback is that these will be user facing descriptions, shown under the page name https://www.thethingsnetwork.org/device-repository/tags/accelerometer/, and these seem more like meta descriptions which could also be used but maybe we need a user facing one as well

It might be nice if we define a structure such as

All LoRaWAN devices that contain ${SENSOR_NAME}. ${SENSOR_NAME} will record ...... data . This can be useful in ${USECASE} .....

?

@mjamescompton mjamescompton removed their assignment Jul 20, 2021
@NicolasMrad NicolasMrad modified the milestones: 2021 Q3, 2021 Q4 Oct 4, 2021
@NicolasMrad
Copy link

is this still relevant?

@mjamescompton
Copy link
Contributor Author

@NicolasMrad yes

@NicolasMrad NicolasMrad modified the milestones: 2022 Q1, 2022 Q2 Mar 30, 2022
@NicolasMrad NicolasMrad modified the milestones: 2022 Q2, 2022 Q3 Jun 27, 2022
@NicolasMrad NicolasMrad modified the milestones: 2022 Q3, 2023 Q1 Oct 10, 2022
@NicolasMrad NicolasMrad removed this from the 2023 Q1 milestone Apr 12, 2023
@NicolasMrad NicolasMrad added this to the 2023 Q2 milestone Apr 12, 2023
@KrishnaIyer KrishnaIyer modified the milestones: 2023 Q2, Backlog Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants