Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement self-service password reset #153

Open
iszulcdeepsense opened this issue Feb 2, 2023 · 3 comments
Open

Implement self-service password reset #153

iszulcdeepsense opened this issue Feb 2, 2023 · 3 comments
Assignees
Labels
SMTP Requires SMTP server in first place

Comments

@iszulcdeepsense
Copy link
Collaborator

We currently have a stub for this with the reset password link, which advises the user to contact an admin. It's probably a good investment in time to flesh this out now, to save the admin time from resetting peoples passwords (like myself, currently).

@iszulcdeepsense iszulcdeepsense added the SMTP Requires SMTP server in first place label Feb 2, 2023
@JosefAssadERST
Copy link
Member

I agree this is very high value.

One detail which makes me a bit leery is, how do we test this? Like in the case of make kind-up. Should there be a prior step requiring the declaration of a working SMTP in config somewhere?

@iszulcdeepsense
Copy link
Collaborator Author

Yeah, testing can be tricky. Maybe it'll be enough to unit test the SMTP interface with some mocks.

I think it should be definitely an optional feature. Not everyone has access to the working SMTP server like we do now.

@JosefAssadERST
Copy link
Member

Well. Not sure about optional, how about graceful failure? It's really common to have self-service account reset, and it's not our fault if someone deployed RT but didn't set SMTP up if that's required for password self-service. But the failure to fire off the mail shouldn't degrade anything else. i don't even think it's RT's job to tell the user the mail couldn't be sent. There shoud maybe just be an admin alert that SMTP isn't configured, and to tell them to set something up. I don't even think RT should be managing queue of mails which failed to send...

@anders314159 anders314159 self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SMTP Requires SMTP server in first place
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants