Feature: Add “Continue” button and badge for selected path #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidha99
force-pushed
the
paths_index_enhancements
branch
from
04f0e19
to
bc05571
Compare
JoshDevHub
requested changes
Apr 24, 2024
davidha99
force-pushed
the
paths_index_enhancements
branch
from
716c2d9
to
fd892c9
Compare
|
Awesome. I'll just wait for Kevin to look things over and maybe create a review deploy for us to preview things. Thank you for contributing 🚀 |
KevinMulhern
requested changes
Apr 30, 2024
There was a problem hiding this comment.
This is looking great @davidha99 💪 thanks for doing this!
Just one small suggestion from me.
app/views/paths/index.html.erb
Outdated
| <div class="absolute top-3.5 right-3.5"> | ||
| <% if current_user.present? && current_user.on_path?(path) %> | ||
| <%= render Ui::BadgeComponent.new(color: 'green') do %> | ||
| <%= @badge_text %> |
There was a problem hiding this comment.
Nit: We can hardcode "Selected" in the badges. I think if we needed the text to be dynamic based on some state, using an instance var would be the way to go. But the content should remain static for now.
Suggested change
| <%= @badge_text %> | |
| Selected |
There was a problem hiding this comment.
Hi @KevinMulhern thanks for the suggestion. I've updated the code 👍
Co-authored-by: Josh Smith <jmsmith1018@gmail.com>
davidha99
force-pushed
the
paths_index_enhancements
branch
from
fd892c9
to
8d3e41d
Compare
KevinMulhern
approved these changes
May 1, 2024
|
Thanks! Glad to help 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
A user might get confused about the current behavior of the "Resume" button in All Paths (#3230, #4495).
This PR
Helps to differentiate a selected path from the rest by:
Note: User needs to be logged in.
Before (Foundations path selected)
After (Foundations path selected)
Before (Ruby on Rails path selected)
After (Ruby on Rails path selected)
Before (Javascript path selected)
After (Javascript path selected)
Issue
Closes #4495
Pull Request Requirements
keyword: brief description of changeformat, using one of the following keywords:Feature- adds new or amends existing user-facing behaviorChore- changes that have no user-facing value, refactors, dependency bumps, etcFix- bug fixesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection