Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add “Continue” button and badge for selected path #4495

Open
2 of 3 tasks
drewstroshine opened this issue Apr 11, 2024 · 10 comments · May be fixed by #4513
Open
2 of 3 tasks

Add “Continue” button and badge for selected path #4495

drewstroshine opened this issue Apr 11, 2024 · 10 comments · May be fixed by #4513
Assignees
Labels
Type: Enhancement Involves a new feature or enhancement request

Comments

@drewstroshine
Copy link

Checks

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Bug: brief description of bug format, e.g. Bug: Lesson complete button does not update on click
  • Would you like to work on this issue?

Bug description

When clicking the "Resume" button on the https://www.theodinproject.com/paths page, it navigates to the course page instead of the last worked on and uncompleted lesson page. The "Resume" button is performing the same behavior as the "View" button. This is in contrast to the "Resume" button on the https://www.theodinproject.com/dashboard page which is working as intended and navigating to that last worked on and uncompleted page.

How to reproduce

  1. Sign in
  2. Navigate to the https://www.theodinproject.com/paths page either by clicking the "View Full Curriculum" button or the "All Path" link in the header
  3. Click the "Resume" button of a path currently in progress and with at least one completed lesson
  4. The "Resume" button navigates to the course page of the path and not the lesson currently being worked on

Expected behavior

  1. Sign in
  2. Navigate to the https://www.theodinproject.com/paths page either by clicking the "View Full Curriculum" button or the "All Path" link in the header
  3. Click the "Resume" button of a path currently in progress and with at least one completed lesson
  4. The "Resume" button navigates to the lesson currently being worked on

What browsers are you seeing the problem on?

Chrome, Safari

What OS are you using?

MacOS

Discord Name

No response

Additional Comments

It appears the "Resume" button on the https://www.theodinproject.com/dashboard page is working as expected so if that same behavior could be transferred to the "Resume" button on the https://www.theodinproject.com/paths page then that might easily fix the bug.

@drewstroshine drewstroshine added Status: Needs Review This issue/PR needs an initial or additional review Type: Bug Involves something that isn't working as intended labels Apr 11, 2024
@KevinMulhern
Copy link
Member

Thanks for making this issue. This isn't a bug, its intended behaviour on our Paths page. We use "Resume" instead of
"View" to indicate which path the learner has selected. But, this has been brought up before #3230, so I wouldn't be against finding a better, less confusing way to differentiate a selected path from the rest - if anyone has any good ideas?

@MaoShizhong
Copy link
Contributor

Perhaps going back to "View" but having a marker of some sort (e.g. "Currently selected") on a selected pathway card?

@drewstroshine
Copy link
Author

What if for a selected path, there is only one "Continue" button instead of the "Resume" and "View" button? My thinking is the "Continue" button would differentiate it from the "Resume" button on the Dashboard page, and it would signify continuing on your path vs resuming your progress on your course?

image

@davidha99
Copy link

Perhaps adding a "Selected" flag on the corner? Like this:

image

I think @drewstroshine idea is also cool.

@KevinMulhern
Copy link
Member

What if for a selected path, there is only one "Continue" button instead of the "Resume" and "View" button? My thinking is the "Continue" button would differentiate it from the "Resume" button on the Dashboard page, and it would signify continuing on your path vs resuming your progress on your course?

This sounds solid, I really like the thought process behind this.

I like the idea of combining "Continue" with a marker/flag - We have a badge component we could use. One of the top corners or beside the title could work:

Screenshot 2024-04-16 at 18 21 36 Screenshot 2024-04-16 at 18 20 54

Although, that might be overkill if "continue" differentiates it enough?

@MaoShizhong
Copy link
Contributor

I like the idea of both the lone "continue" button and the "selected" badge (either placement looks 🔥)

@davidha99
Copy link

I like the idea of both the lone "continue" button and the "selected" badge (either placement looks 🔥)

I like that idea too

@drewstroshine
Copy link
Author

I like the idea of both the lone "continue" button and the "selected" badge (either placement looks 🔥)

I like that idea too

Same here 👍

@davidha99
Copy link

I see there's no one assigned to this issue, I'll be happy to work on this

@KevinMulhern KevinMulhern added Type: Enhancement Involves a new feature or enhancement request and removed Type: Bug Involves something that isn't working as intended Status: Needs Review This issue/PR needs an initial or additional review labels Apr 19, 2024
@KevinMulhern
Copy link
Member

Thanks @davidha99, I've assigned it to you.

@drewstroshine drewstroshine changed the title Bug: Resume button on "All Paths" page does not resume and does the same action as "View" button Add “Continue” button and badge for selected path Apr 19, 2024
@davidha99 davidha99 linked a pull request Apr 24, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Involves a new feature or enhancement request
Projects
Status: 📋 Backlog / Ideas
Development

Successfully merging a pull request may close this issue.

4 participants