Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Replace deprecated / division #4351

Open
3 of 4 tasks
mgrigoriev8109 opened this issue Jan 19, 2024 · 2 comments
Open
3 of 4 tasks

Chore: Replace deprecated / division #4351

mgrigoriev8109 opened this issue Jan 19, 2024 · 2 comments
Labels
Status: Needs Review This issue/PR needs an initial or additional review Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.

Comments

@mgrigoriev8109
Copy link
Contributor

Checks

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Chore: brief description of chore format, e.g. Chore: Lesson complete button does not update on click
  • Would you like to work on this issue?

Chore description

Running rspec on main prints DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. in the terminal`, so figure that should be addressed.

image

The top answer in this SO question links to why this is happening and provides possible alternatives.

Acceptance criteria

  • Replace / for division with non-deprecated alternative.

Additional Comments

No response
@mgrigoriev8109 mgrigoriev8109 added Status: Needs Review This issue/PR needs an initial or additional review Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. labels Jan 19, 2024
@Asartea
Copy link
Contributor

Asartea commented Jan 19, 2024

This is caused by dkniffin/active_material; I have an open PR on that, but that isn't merged yet dkniffin/active_material#90

@KevinMulhern
Copy link
Member

Thanks for doing that @Asartea 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Review This issue/PR needs an initial or additional review Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.
Projects
Main Site
Status: 📋 Backlog / Ideas
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KevinMulhern @mgrigoriev8109 @Asartea