Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: broken link in rules page. #4101

Closed
2 of 3 tasks
ManonLef opened this issue Aug 28, 2023 · 6 comments
Closed
2 of 3 tasks

Bug: broken link in rules page. #4101

ManonLef opened this issue Aug 28, 2023 · 6 comments
Assignees
Labels
Status: Needs Review This issue/PR needs an initial or additional review Type: Bug Involves something that isn't working as intended

Comments

@ManonLef
Copy link
Member

ManonLef commented Aug 28, 2023

Checks

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Bug: brief description of bug format, e.g. Bug: Lesson complete button does not update on click
  • Would you like to work on this issue?

Bug description

the "improve this lesson on GitHub" button doesn't link to the correct file anymore.

I know @JoshDevHub has been working on making this file an md file instead (thanks for that by the way!) and I kind of lost track about the progress on the full conversion.

How to reproduce

  1. Go to this page which contains our rules
  2. click the link at the bottom "improve this lesson on GitHub"
  3. be met with a 404

Expected behavior

  1. Go to this page which contains our rules
  2. click the link at the bottom "improve this lesson on GitHub"
  3. be met with the file on GH

What browsers are you seeing the problem on?

Safari

What OS are you using?

MacOS

Discord Name

No response

Additional Comments

No response

@ManonLef ManonLef added Type: Bug Involves something that isn't working as intended Status: Needs Review This issue/PR needs an initial or additional review labels Aug 28, 2023
@Asartea
Copy link
Contributor

Asartea commented Aug 28, 2023

I know @JoshDevHub has been working on making this file an md file instead (thanks for that by the way!) and I kind of lost track about the progress on it.

Thats #4022 which is still in progress I think.

This issue is caused by the old shift from views/static_pages/page-name to views/guides/community/page-name. For now I think https://github.com/TheOdinProject/theodinproject/blob/main/app/views/guides/community/rules.html.erb is still the page that its pulled from, so the link should be repointed to there

@ManonLef
Copy link
Member Author

ManonLef commented Aug 28, 2023

@Asartea thanks. The file itself is already merged in top-meta. I am sorry about the confusion, I was more interested in the entire move/overhaul. If the status is nearing completion it would make more sense to point to the intended file residence and not the (possibly soon) old erb file.

@Asartea
Copy link
Contributor

Asartea commented Sep 16, 2023

@ManonLef given thats it been 3 weeks, I think its probably worth taking them time to fix it

@ManonLef
Copy link
Member Author

@Asartea you're free to work on it if you want :). Considering we have other team members working on related issue with the md switch, this issue has no priority/rush at the moment for us to bump since it's expected to be caught in there. But do let me know if you want it assigned to you!

@Asartea
Copy link
Contributor

Asartea commented Sep 16, 2023

Should be a quick enough fix; I'll do it

@KevinMulhern
Copy link
Member

Resolved by: #4149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This issue/PR needs an initial or additional review Type: Bug Involves something that isn't working as intended
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants