Bug - 04_removeFromArray: missing test case

[Sarthak-Malla]

Complete the following REQUIRED checkboxes:

• I have thoroughly read and understand The Odin Project Contributing Guide
• The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - Exercises: File type incorrect for all test files

The following checkbox is OPTIONAL:

• I would like to be assigned this issue to work on it

---

1. Description of the Bug:

The testing for the solution has a missing test case that looks into if all the elements in the Array that matches the element to be deleted is properly deleted.

In other words, the Array from which the elements are supposed to be deleted from has no repeating values. So, the test case does not directly prompt the user to write code that deletes all the instances of the element that is supposed to be deleted from the Array.

2. How To Reproduce:

• Write the code that satisfies all the 7 cases in the 04_removeFromArray exercise.
• Open the `removeFromArray.spec.js` file and modify the 5th test case such that the initial array has [1, 2, 2, 3, 4]
• Run the code again.

3. Expected Behavior:

If the code written does not account for repeated values like the one below, the modified test case (5th test case) results to a failure.

const removeFromArray = function(...arg) {
    const arr = arg[0];
    arg.splice(0,1);

    for (let i = 0; i < arg.length; i++) {
        for (let j = 0; j < arr.length; j++) {
            if (arg[i] === arr[j]) {
                arr.splice(j, 1);
                // j--;
            }
        }
    }

    return arr;
};

Note: Line 9 is commented such that the test case is not matched!

4. Desktop/Device:

• Device:
• OS:
• Browser:
• Version:

5. Additional Information:

[thatblindgeye]

@Sarthak-Malla would you still be interested in working on this?

[Sarthak-Malla]

@Sarthak-Malla would you still be interested in working on this?

Hey, i would love to. How should I proceed?

[thatblindgeye]

@Sarthak-Malla We'd need a new test added to both the removeFromArray.spec.js file as well as the solution's removeFromArray-solution.spec.js file. For the normal spec.js file the test should be skipped. We could just copy+paste one of the existing tests and tweak it to something like:

test.skip('removes all instances of a value', () => {
  expect(removeFromArray([1, 2, 2, 3], 2)).toEqual([1, 3]);
});

Or however you think makes sense to write the test.

[thatblindgeye]

@Sarthak-Malla just checking in on the status of this

[Sarthak-Malla]

@thatblindgeye Hey, I am really sorry. I am caught in load of work, is it possible to re-assign this to someone else?