What is JSX?: Remove ordered list from examples to prevent a markdown issue #27769
Conversation
…ered elsewhere. Adjust the text accordingly
…ect the indentation of the <circle> elements
There was a problem hiding this comment.
Thanks for doing this @Darknab.
I can't add individual comments below since they're not part of the diff, but we'd also need to change 175 do not mention the class bit, as we now only have to deal with changing stroke-width to strokeWidth.
Side request while we're at it, on line 45 there's a comment. Could you move that comment to above the return please?
i.e.
```jsx
function App() {
// Could replace <></> with <div></div>
return (
<>
<h1>Example h1</h1>
<h2>Example h2</h2>
</>
);
}
```
|
Ok @MaoShizhong, I'm on it! |
…e example. Move the comment from line 45 to line 40. Correct indentation.
|
Can someone help me on solving this lint error please? |
Likely would be because those rules were added after your created the branch for this PR. For future PRs, if you update your fork's main then make a new branch off that updated main, then you'll have all the new stuff. |
Syncing fork with the updated main
There was a problem hiding this comment.
Thanks for fixing up the KC links.
Just noticed that your previous commit converted the 3-space indentation for the ordered list children to 2 spaces.
Could you please revert these to 3 spaces?
Ordered list items that take up multiple lines need all lines to start with a 3-space indent as per our [layout style guide], else they won't be considered part of the same item.
If you put your markdown into the markdown preview tool, you'll notice that the relevant ordered list contains only 1. instead of 1. 2. 3., because of the 2-space indent. The actual content won't be visually indented either, as opposed to with a 3-space indent where it's clear what content is part of which ol item.
Reverting them back to a 3-space indent will fix this.
Because
Missing closing tags on li elements were causing a problem with the links in the "Lesson content" section.
This PR
Issue
Closes #27737
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection