Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actions to reduce unintentional PRs #527

Open
3 tasks done
fabulousgk opened this issue Apr 21, 2024 · 1 comment
Open
3 tasks done

Use actions to reduce unintentional PRs #527

fabulousgk opened this issue Apr 21, 2024 · 1 comment
Labels
Status: Needs Review This issue/PR needs an initial or additional review Type: Bug Involves something that isn't working as intended

Comments

@fabulousgk
Copy link
Contributor

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - Grid exercises: CSS not properly linked to HTML files

The following checkbox is OPTIONAL:

  • I would like to be assigned this issue to work on it

Before I spend a lot of time looking into how to do this...would the maintainers be open to an action that automatically closes any PR without a linked issue, in this and the other exercise repos. The idea being that all the unitinended PRs are closed without effort from the maintainers, but still allowing legit PRs to stay open.

@fabulousgk fabulousgk added Status: Needs Review This issue/PR needs an initial or additional review Type: Bug Involves something that isn't working as intended labels Apr 21, 2024
@MaoShizhong
Copy link
Contributor

Thanks for making this suggestion @fabulousgk.
Had a little chat with some of the others and we're not we'd want to introduce this kind of action, even if we were to change the relevant repos' actions behaviours to run for first-time contributors.

While it might mean we no longer to manually close unwanted PRs, the proposed method would also catch any genuine PRs without linked issues. We don't actually require an issue, particularly for small fixes which are perfectly fine to directly PR without having to issue and wait for assignment. So there might be new issues that arise for us to deal with like handling mistakenly closed PRs or the like.

While that's not a huge issue, it's also not really that big of a deal to close these solution PRs since they don't come in all too often, and closing a few of them every now and then isn't too cumbersome of a task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review This issue/PR needs an initial or additional review Type: Bug Involves something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants