Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with UTF-8 encoding #117

Open
goossensk opened this issue Apr 19, 2023 · 1 comment
Open

Issue with UTF-8 encoding #117

goossensk opened this issue Apr 19, 2023 · 1 comment

Comments

@goossensk
Copy link

Hello, I'm having names with diacritics like ë, and they are not correctly imported using the UTF-8 enoding.

Debugging what is going wrong:

  • GedcomRecordReader.ReadHeaderRecord is checking for "UTF8", while its mentioned in the gedcome file as "UTF-8".

  • Even when I would update the gedcom file to use UTF8, then within this case, its only setting the charset and not setting any encoding itself.

@goossensk
Copy link
Author

Updated and tested with the following fixed the issue for me.

case "UTF8":
// this is correct, we will already have converted from utf8
charset = GedcomCharset.UTF16LE;
enc = Encoding.UTF8;
break;
case "UTF-8":
// this is correct, we will already have converted from utf8
charset = GedcomCharset.UTF16LE;
enc = Encoding.UTF8;
break;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant