Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xAxisData not showing. #91

Open
mrabbi-hishabee opened this issue Sep 26, 2023 · 5 comments
Open

xAxisData not showing. #91

mrabbi-hishabee opened this issue Sep 26, 2023 · 5 comments

Comments

@mrabbi-hishabee
Copy link

Details:
I use this library in an XML-based project. It works fine but xAxisData data not showing.

Example:
image

Code:
@composable
fun BarChartSample(xAxisData: List, testBarParameters: List) {
xAxisData.toString().logDebug("RABBI")
BarChart(
legendPosition = LegendPosition.DISAPPEAR,
chartParameters = testBarParameters,
barCornerRadius = 2.dp,
gridColor = Color.LightGray,
xAxisData = xAxisData,
isShowGrid = true,
showXAxis = true,
showYAxis = true,
animateChart = true,
showGridWithSpacer = true,

    yAxisStyle = TextStyle(
        fontSize = 12.sp,
        color = Color.Gray,
    ),
    xAxisStyle = TextStyle(
        fontSize = 12.sp,
        color = Color.Gray,
        fontWeight = FontWeight.W400
    ),
    barWidth = 20.dp
)

}

@amnah44
Copy link
Collaborator

amnah44 commented Sep 27, 2023

Unfortunately, this is an issue in our library we will fix it in the next release.

@MahmoudMabrok
Copy link

@amnah44 could you share list of issues will be fixed in next release and expected date ?

@jalalaghazadeh
Copy link

Unfortunately, this is an issue in our library we will fix it in the next release.

by reading code-base, it's obvious that you decide to stop drawing xDataAxis but I don't realize why you should do that (may be there was a bug in 'xAxisDrawing'):

if (showXAxis) {
        if (!isFromBarChart) {
            xAxisDrawing(
                xAxisData = xAxisData,
                textMeasure = textMeasure,
                xAxisStyle = xAxisStyle,
                specialChart = specialChart,
                upperValue = upperValue,
                xRegionWidth = xRegionWidth
            )
        }
    }

where 'isFromBarChart' is always true!

could you please fix it?

@amnah44
Copy link
Collaborator

amnah44 commented Oct 30, 2023

@MahmoudMabrok Most of our team members are college students so we fix this issue in our vacation or free time, so I can't give you an expected date for next release but we are trying to fix all this issue here before new year. and thanks for your ask.

@amnah44
Copy link
Collaborator

amnah44 commented Oct 30, 2023

@MahmoudMabrok Thanks for your question and I would like to clarify that we are making this class as a base class able to use for all schemes of our charts now and in the future and we are fixing the UI, not the code issue because every team has plans, goals, ideas and decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants