Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] there is nested ripple effects in small screens sidebar component #288

Open
AbdulrhmanGoni opened this issue May 6, 2024 · 0 comments · May be fixed by #289
Open

[BUG] there is nested ripple effects in small screens sidebar component #288

AbdulrhmanGoni opened this issue May 6, 2024 · 0 comments · May be fixed by #289

Comments

@AbdulrhmanGoni
Copy link
Contributor

What would you like to share?

Description of the issue

The Button component in small screens sidebar has ripple effect appears on hover or click events,
And this component is placed inside MenuItem component which has the same ripple effect, so,
this structuring causes nested ripple effects as you see in the screenshots below 👇

Screenshots

Screenshot (61)
Screenshot (62)

Additional information/context

No response
@AbdulrhmanGoni AbdulrhmanGoni linked a pull request May 6, 2024 that will close this issue
Open
4 tasks
@AbdulrhmanGoni AbdulrhmanGoni changed the title [OTHER] there is nested ripple effects in small screens sidebar component [BUG] there is nested ripple effects in small screens sidebar component May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@AbdulrhmanGoni