Enhancements for stack implementation using slice #544
Conversation
BulkBeing
requested review from
siriak,
raklaptudirm,
tjgurwara99 and
yanglbme
as code owners
There was a problem hiding this comment.
I have a few general thoughts that I think might actually be better for this implementation.
First thing to note is that there is already an implementation of Stack. This means that to make this into a really self contained package, I think you should create an interface that both implementations adhere to and expose only the interface outside the package, but this is non-blocking.
The comment is blocking however.
BulkBeing
force-pushed
the
stack-enhancements
branch
from
5260991
to
67b4562
Compare
| package stack | ||
|
|
||
| import ( | ||
| "container/list" |
There was a problem hiding this comment.
Please use our internal data structures when creating new ones. Using container package hides a lot of material that could be used for learning.
There was a problem hiding this comment.
This code was already present (I just renamed the file). Since there is another implementation using linked list, shall I remove this one?
There was a problem hiding this comment.
Keep it there, but create a new Issue to fix this 🙏🏼
BulkBeing
force-pushed
the
stack-enhancements
branch
from
b7f0806
to
3268f14
Compare
| } | ||
| }) | ||
|
|
||
| st.Pop() |
There was a problem hiding this comment.
This needs to be checked. Please fix all the listing and styling errors raised by the CI.
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Closes #543