Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event.close not called in some situations #828

Open
jacob1 opened this issue Feb 22, 2022 · 0 comments
Open

event.close not called in some situations #828

jacob1 opened this issue Feb 22, 2022 · 0 comments

Comments

@jacob1
Copy link
Member

jacob1 commented Feb 22, 2022

event.close sometimes isn't called when exiting the game due to buggy window management in Engine.cpp

Steps:

  • Make sure Fast Quit is on
  • Open a secondary interface like the save browser or console
  • Exit TPT

I can fix this, but the problems with the UI design are severe and also likely solved by redo-ui. Rather than risk crashes (due to changing the whole window ownership model, or because of Lua interface ownership issues), I'll just open this issue and hope we can close this issue when redo-ui is finished.

Regarding the window ownership issues, I posted a bunch of info on this on IRC back on September 3rd. I didn't catch the user-facing bug in the Lua event api back then, only the memory management issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant