Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybinding issues on non-QWERTY keyboard #737

Open
SamantazFox opened this issue Oct 18, 2020 · 4 comments
Open

Keybinding issues on non-QWERTY keyboard #737

SamantazFox opened this issue Oct 18, 2020 · 4 comments
Labels
Usability issue steps lead to undesirable outcome

Comments

@SamantazFox
Copy link

It doesn't respect the OS keybinding, for instance on AZERTY, undo is ctrl+W.

This also makes the F1 help totally useless for non-QWERTY users.

@LBPHacker
Copy link
Member

@jacob1

@LBPHacker LBPHacker added the Usability issue steps lead to undesirable outcome label Oct 18, 2020
@jacob1
Copy link
Member

jacob1 commented Oct 18, 2020

This is intentional. It is annoying that the help text is wrong though.

TPT has nearly every single key on the keyboard mapped to something, letters and special characters. It also has ctrl+key or shift+key for a lot of keys mapped too. On many layouts, you start running into issues with special characters if they don't have their own keys. For example, on US layout [ and ] change the brush shape, then we have shift+[ ] and ctrl+[ ] to change just the width and height. This would not work on any keyboard layout where [ and ] don't have their own keys, because if you already need to press shift to use those keys, you can't have every shortcut.

For an actual example of this, see this forum post https://tpt.io/.307621 . On some layouts, [ and ] were actually not working at all, because it came in as a shift+8 and shift+9.

So we use sdl scancodes to get the position of the key that was pressed, and do actions based on the position, and not the actual character written on that key. This allows nearly every layout to use nearly every shortcut. TPT has been this way from the beginning (with the exception of that bug I caused), and generally people are fine with this.

@SamantazFox
Copy link
Author

Oh, okay, thanks for the quick reply !

Is an option menu for keybindings possible?

@LBPHacker
Copy link
Member

We actually have a (now defunct) PR open for a bit of UI that lets you edit keybindings. It ended up being too big of a changeset for the contributor to properly plan out and for us to easily integrate, so we postponed merging it indefinitely. It's currently not a huge priority, but either that or some passive help dialog that just lists keybindings will definitely be added to the game at some point. I guess I'll just keep this issue open until that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Usability issue steps lead to undesirable outcome
Projects
None yet
Development

No branches or pull requests

3 participants