Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Air displays supress persistent effect #627

Open
ghost opened this issue Jan 21, 2019 · 3 comments
Open

Air displays supress persistent effect #627

ghost opened this issue Jan 21, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 21, 2019

Go into the renderer options and enable element path persistence. Then enable any one of the three pressure/velocity displays.

Path persistence stays on but will immediately cease to render.

When going the other way (air then persistence), the air mode will be automatically disabled.

@jacob1
Copy link
Member

jacob1 commented Jan 21, 2019

Noticed this when looking into #579 last week. Decided not to fix that issue for now because I don't want to get into it at the moment, it's too complicated.

(probably won't fix this for a while either)

@ghost
Copy link
Author

ghost commented Jan 21, 2019

The way that persistence disables air (as in, the box becomes unchecked) implies an easy fix would be to make air disable persistence in the same fashion, surely?

Then it can all render properly while all the other persistence problems are ironed out.

@jacob1
Copy link
Member

jacob1 commented Jan 21, 2019

I don't know if that's intentional that air gets disabled. Renderer::AddDisplayMode removes all air display modes when adding a new one. So perhaps it is intentional, but it's done in a really obviously wrong way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant