Flood-filling decoration is affected by UI elements such as the zoom window

[ghost]

If you zoom in on a homogeneously-coloured block and use ctrl+shift+click on it, the interior, border, exterior of and area behind the zoom window are treated like separate areas.

It doesn't matter whether you click inside the large or small zoom window, its border, something around it or around the large window.

[iczero]

Wouldn't this be intended behavior? It sounds awfully like it was done intentionally.

[ghost]

Definitely not, judging by what happens in all the different ways you can click outside the zoom window. Especially what happens when flood-filling whatever occupies the corner where the large zoomed window is.

[jacob1]

The new title makes less sense?

Anyway this one of those things I say "it's not a bug, it's a feature!" I knew about it when adding deco flood fill. I may or may not eventually fix it but it's very low priority.

[ghost]

The benefits of coming back to something after an extended period of time.

When flood-filling, it applies that decoration to everything connected that renders the same colour. So there are a lot of unintended side-effects:

• overlays of all kinds block it
  • both parts of the zoom window
  • HUD
  • fire effect glow
  • centre text, e.g. "Air: Off"
  • element info in bottom right
• something undecorated and something (same or different element) coloured to look the same will be affected together
• if something is decorated with multiple colours, e.g. sand effect, disabling decoration display allows the whole thing to be coloured simultaneously.

fake edit: have patience, @jacob1

[ghost]

This was a single flood-fill operation. Surely not intended behaviour.

[jacob1]

Using "displayed" color is entirely intentional. All the overlay issues you mentioned are bugs though. The thing with a decoed element and a non decoed element both being flood filled is intentional, because they are the same color. Same with the sand effect thing, that is also intentional.

It should take a snapshot of the screen before rendering the UI objects. Then it can flood fill properly.

[ghost]

@jacob1 Not entirely sure how to phrase it. Feel free to change the title if you have something better :)

Though I don't agree that sand effect should work differently because you disabled deco rendering.

Another repro: try zooming into the area under the top HUD, and flood-filling inside the enlarged zoom window. Doesn't even cover the whole thing.

[jacob1]

Deco flood fill flood fills based on the color on the screen. So of course decoration color will affect it. The only bug is that UI elements shouldn't affect.

Deco flood fill is different from other types of flood fills. Other types flood fill based on elements, but deco flood fills based on the color displayed on the screen.

[ghost]

Fair enough. I was just listing as many tangentially-related examples of the underlying cause as I could. That's behaviour I dispute but don't oppose, if you know what I mean :)

Title's definitely better now.

[ghost]

Flood-filling on the empty background will colour anything that is dark.