Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo for 2.0 #249

Closed
3 tasks
ThaDafinser opened this issue Oct 21, 2016 · 7 comments
Closed
3 tasks

Todo for 2.0 #249

ThaDafinser opened this issue Oct 21, 2016 · 7 comments

Comments

@ThaDafinser
Copy link
Owner

ThaDafinser commented Oct 21, 2016

Cleanup

setRendererName()

The renderer is now set though the setRendererService() method, so this method has no affect anymore
https://github.com/ThaDafinser/ZfcDatagrid/blob/master/src/ZfcDatagrid/Datagrid.php#L789-L792

  • remove the code
  • update docs
  • bc break (method removed)
@ThaDafinser ThaDafinser changed the title cleanup setRendererName cleanup 2.0 Oct 21, 2016
@ThaDafinser ThaDafinser changed the title cleanup 2.0 Todo for 2.0 Oct 21, 2016
@kokspflanze
Copy link
Collaborator

from my site we should also update all tests to use ::class and not smth like https://github.com/ThaDafinser/ZfcDatagrid/blob/v1.3.0/tests/ZfcDatagridTest/DatagridTest.php#L160

we should also remove https://github.com/ThaDafinser/ZfcDatagrid/blob/v1.3.0/src/ZfcDatagrid/Datagrid.php#L1163
because of the changes of zend-mvc 2.7

@ThaDafinser
Copy link
Owner Author

Require PHP 7 + ZF3

@kokspflanze
Copy link
Collaborator

if we should only support PHP7, than we should also only support PHPUnit6 see sebastianbergmann/phpunit#1751

@kokspflanze
Copy link
Collaborator

today i tried to set min PHP7 https://github.com/kokspflanze/ZfcDatagrid/tree/patch-5 the current problem i have is HHVM,

any one have a good idea expected --ignore-platform-reqs and remove hhvm from travis?

@ThaDafinser
Copy link
Owner Author

@kokspflanze i will get tomorrow back, where i will have some time to check the open issues and PR

@ThaDafinser
Copy link
Owner Author

ThaDafinser commented Nov 18, 2016

@kokspflanze the temporary solution seems to be this part
composer/composer#4976

I guess I'll just move hhvm to the allow_failures list at Travis and use --ignore-platform-reqs until HHVM's PHP 7 compatible.

@ThaDafinser
Copy link
Owner Author

This issue was moved to zfc-datagrid/zfc-datagrid#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants