-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Todo for 2.0 #249
Comments
from my site we should also update all tests to use we should also remove https://github.com/ThaDafinser/ZfcDatagrid/blob/v1.3.0/src/ZfcDatagrid/Datagrid.php#L1163 |
Require PHP 7 + ZF3 |
if we should only support PHP7, than we should also only support PHPUnit6 see sebastianbergmann/phpunit#1751 |
today i tried to set min PHP7 https://github.com/kokspflanze/ZfcDatagrid/tree/patch-5 the current problem i have is HHVM,
any one have a good idea expected |
@kokspflanze i will get tomorrow back, where i will have some time to check the open issues and PR |
@kokspflanze the temporary solution seems to be this part
|
This issue was moved to zfc-datagrid/zfc-datagrid#30 |
Cleanup
setRendererName()
The renderer is now set though the setRendererService() method, so this method has no affect anymore
https://github.com/ThaDafinser/ZfcDatagrid/blob/master/src/ZfcDatagrid/Datagrid.php#L789-L792
The text was updated successfully, but these errors were encountered: