Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E/D and SPACE docs need to reflect new, corrected treatment of porosity #140

Open
cmshobe opened this issue Jun 20, 2019 · 3 comments
Open
Assignees

Comments

@cmshobe
Copy link
Contributor

cmshobe commented Jun 20, 2019

Which means that now there is no porosity term in the Qs_in calculation, and there is porosity adjustment for both E and D in all models and all solvers, rather than just a correction for D.

@kbarnhart
Copy link
Contributor

@cmshobe This change in Landlab appears to break only a small number of test (rather than all the tests that use a Hy variant model). Does this make sense to you?

See, for example, this build.

The tests that break are all in tests/test_model_basicHyRt.py.

Please address these changes. It would be great if you could do it on the following branch:

git fetch origin
git checkout -b barnhark/fix_few_bugs origin/barnhark/fix_few_bugs

When you have made your fixes, there may still be a few failures because @Glader011235 is making changes too based on #142 .

@cmshobe
Copy link
Contributor Author

cmshobe commented Jul 12, 2019

I'll check it out-- don't know a priori why not all tests are failing.

@kbarnhart
Copy link
Contributor

@cmshobe I was able to fix this by slightly relaxing the decimal precision of the comparison and increasing the number of iterations in the test.

Am I correct in thinking that the change in landlab should not have affected any tests b/c there is no phi in the steady solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants