Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author order is not preserved in the credits list #725

Open
haykam821 opened this issue Apr 30, 2024 · 3 comments · May be fixed by #726
Open

Author order is not preserved in the credits list #725

haykam821 opened this issue Apr 30, 2024 · 3 comments · May be fixed by #726
Labels
bug A problem with the project

Comments

@haykam821
Copy link
Contributor

As of #706, credits for Fabric mods now separate by authors and contributors, with each list being sorted alphabetically.

However, authors are often listed in a particular order, meaning that the primary author of a mod may be sorted after its secondary authors. This behavior is also inconsistent with the order shown in the authors list next to the icon.

To keep the intent of the authors list, I believe that authors should not be sorted within the credits.

@LostLuma
Copy link
Contributor

LostLuma commented May 1, 2024

I don't think that the author or contributor order is actually guaranteed to be equal to the order in the json file on either Fabric or Quilt. I reverted the last two commits on the PR and looked at a mod with a lot of contributors in ModMenu and the contributors are in random order, even though in the source file they are sorted alphanumerically. (Same situation on Quilt, obviously.)

@Prospector
Copy link
Member

Hmm, weird. I think this must be a recent change or possibly just something that happens outside of dev? I always observed it being in the json order, as I sort authors by seniority and contributors in chronological order

@LostLuma
Copy link
Contributor

LostLuma commented May 1, 2024

I realized my testing was flawed because I inserted the list of names into a collection that doesn't preserve order.

@LostLuma LostLuma linked a pull request May 1, 2024 that will close this issue
@haykam821 haykam821 added the bug A problem with the project label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem with the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants