Added a non constant Temperature and Humidity Facet Provider #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyTechGuy
requested changes
Apr 21, 2020
There was a problem hiding this comment.
For world generation stuff, it is standard to use noise-based float values over random float values. This is done so if the same seed is used in world generation, the same world will be created every time.
Please replace the random.nextFloat() statements with some form of noise sampling. This section of the world generation tutorial may be a good thing to reference 😄
| @@ -65,7 +67,7 @@ public void process(GeneratingRegion region) { | |||
| // TODO: Setup humidity | |||
There was a problem hiding this comment.
Remove TODO comments like this, since the humidity/temperature is now set up by this PR.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temperature and Humidity Facet Provider
Fixes #38.
Currently, the Temperature and Humidity are fixed at 0.6f and 0.1f respectively. This PR adds some variability to it by adding a weighted probability that ensures that the resulting Biome is a Desert.