Citizen Asset References in Code

[jdrueckert]

When replacing the placeholder gooey models for bad and good citizens, I added the respective assets named [bad|good]Robot and removed the old [bad|good]Citizen assets. While the prefabs could be spawned perfectly well with spawnPrefab [bad|good]Robot, the citizen spawning mechanism in the MetalRenegades cities and the Minimap didn't work. Assumedly it still tried to use the citizen assets instead of the new robot assets.

I found mentions in FactionAlignmentSystem.java:48 and CharacterOverlay.java:62, but adjusting these to the robot asset names didn't help either. So, this seems to be referenced somewhere in the MR code in a way that is not easy to find with grep or similar tools.

As a result, I created #110 and renamed all assets to the citizen variant again which fixed things. But this kind of hard-coded reference should be removed as it complicates any changes in that area very much.