Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some discussions about PyDebloatX packaging. #42

Open
space9bug opened this issue Jan 5, 2021 · 13 comments
Open

Some discussions about PyDebloatX packaging. #42

space9bug opened this issue Jan 5, 2021 · 13 comments

Comments

@space9bug
Copy link
Contributor

  1. Package size(It's not big, so you can use solid. Network transmission is always slow.)
    LZMA(Solid)
  2. Deletable DLL(We can add it again when we need to.)
    libEGL.dll
    libGLESv2.dll
    opengl32sw.dll
    Qt5DBus.dll
    Qt5Network.dll
    Qt5Qml.dll
    Qt5QmlModels.dll
    Qt5Quick.dll
    Qt5WebSockets.dll
  3. Version(It just runs on Windows 10.)
    Latest Python 3 Release - Python 3.9.1
    32-bit and 64-bit
@Teraskull
Copy link
Owner

Ok, I will later test if PyInstaller is stable enough for Python 3.9.1, and will test the 32-bit version as well.

Also, it would be better to rename the portable version PyDebloatX_portable.exe instead of PyDebloatX.exe, so it could go along with the PyDebloatX_setup.exe.

Regarding the deletable DLLs, is deleting them with the bat file the best way?

Didn't look at LZMA compression yet, would it work in our case?

@space9bug
Copy link
Contributor Author

  1. NSIS settings
    LZMA(Solid)
  2. Two ways: PyDebloatX.spec or bat

@Teraskull
Copy link
Owner

  1. Aha, got it.

  2. bat would be good.

@Teraskull
Copy link
Owner

For good Python 3.9 support, we should migrate to PyQt6, or PySide6.

https://www.qt.io/blog/qt-for-python-6-released

@space9bug
Copy link
Contributor Author

PyQt5 PyQt6 PySide6
lupdate yes yes yes
rcc yes no yes
uic yes yes yes
32bit yes no no
64bit yes yes yes

Latest version: qt5-applications 5.15.2.2.1

@space9bug
Copy link
Contributor Author

Currently available:
Python 3.9.1
pyinstaller 4.1
PyQt5 5.15.2

@Teraskull
Copy link
Owner

Too bad that PySide6 does not support 32 bit. We will have to stay on PyQt5 for now then.

@Teraskull
Copy link
Owner

But in my opinion, we should try migrating to PySide6 for support and license reasons. Right now PyDebloatX is licensed MIT, which does not permit the whole license range, because of the PyQt5 GPL license.

@Teraskull
Copy link
Owner

Yea, PySide6 is not an option until PyInstaller merges this commit: pyinstaller/pyinstaller#5418

@space9bug
Copy link
Contributor Author

I found a solution. Manually package the missing files.
File list:
PySide6\plugins
PySide6\translations
PySide6\qt.conf

@Teraskull
Copy link
Owner

We will still have to wait for the PyInstaller Develop branch, in order to not break the workflow, manually packaging files.

@space9bug
Copy link
Contributor Author

According to the download data of PyDebloatX 1.10.0, I found that very few people use 32bit. PySide6 and PyQt6 also only support 64bit, so we can cancel the 32bit support. We only release PyDebloatX_portable.exe and PyDebloatX_setup.exe. For the time being, PyInstaller officially cannot package Qt6 applications perfectly. We can improve the code. After both parties confirm, release the last version that supports Qt5.

@Teraskull
Copy link
Owner

Yes, I also saw the statistics and decided to discontinue the 32-bit support. If anyone needs it, the 1.10.0 version is pretty stable.

We will wait until PyInstaller works with PySide6, and then migrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants