Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: key error in weight_dict & losses #48

Open
zhiyuanyou opened this issue Dec 14, 2022 · 1 comment
Open

[Bug]: key error in weight_dict & losses #48

zhiyuanyou opened this issue Dec 14, 2022 · 1 comment

Comments

@zhiyuanyou
Copy link

In models/p2pnet.py:

Line 278: losses['loss_point'] = loss_bbox.sum() / num_points
Line 335: weight_dict = {'loss_ce': 1, 'loss_points': args.point_loss_coef}

one is "loss_points" and another is "loss_point" (an "s" is different) ! This would cause that the point loss is actually not used, which is fully wrong!

@zhiyuanyou zhiyuanyou changed the title [Bug]: key wrong in weight_dict & losses [Bug]: key error in weight_dict & losses Dec 14, 2022
@dddddasda
Copy link

I found that too, but I can get results comparable with the official ones on ShanghaiTech A dataset even without point loss item. How about you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants