Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get modal instance and set a parent modal #255

Open
gabrielberlanda opened this issue Feb 17, 2019 · 6 comments
Open

Get modal instance and set a parent modal #255

gabrielberlanda opened this issue Feb 17, 2019 · 6 comments

Comments

@gabrielberlanda
Copy link

First of all, thanks for your good library.

Is your feature request related to a problem? Please describe.
Yes, the modal documentation is not clear, I spend some time figuring out that I have to import the "ContainerModalModule" to use the modalModule, your library is amazing, but the documentation should be improved.

Describe the solution you'd like
I would like to get access to a new modal instance and pass data to it, Is it possible?
I would like to create a modal with a parent modal, and when close the parent modal, the child should be closed too, Is it possible nowadays?

Additional context
I would love to use your library in my graduation project, but, is this library ready to use in production?

@welcome
Copy link

welcome bot commented Feb 17, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@abalad
Copy link
Member

abalad commented Feb 22, 2019

Hello. First of all thank you for using and liking our library. We are improving LIB as we are using it in our Base projects. That is, yes it can be applied in production.

And because our team is small we can not update all the documentation as the framework grows. We apologize for this inconvenience, but with the help and use of it by the community we will improve quickly.

I will update the documentation tomorrow as much as I can, taking into account your questions. ;)

@WilliamAguera
Copy link
Member

WilliamAguera commented Feb 22, 2019

There's no feature of "parent" and "child" modals, but you can define an "ID" passed by param, to close it on "then" method of the promise returned by your parent modal.

So. You can access the getModal method to close the modal.

Ex: this.modalService.getModal("MODAL_ID").close()

@tayambamwanza
Copy link

tayambamwanza commented Jul 11, 2019

@abalad Hi, brand new user, there is a still a problem with documentation, I only found out now what I need to do from this post.

I love the work you guys are doing and would love to recommend you.

I will see if I can contribute with documentation once in a while if you're willing to use me.

@abalad abalad reopened this Jul 11, 2019
@abalad
Copy link
Member

abalad commented Jul 11, 2019

@tayambamwanza Hello, Thank you for using our LIB, we are very happy. We are currently rewriting our documentation and soon we will be providing more complete documentation where it will include all the nuances of TRULY-UI.

If you want to help as soon as you are ready, the central documentation repository can open PRs through the.

@abalad
Copy link
Member

abalad commented Jul 11, 2019

This issue I opened again to remind us that it has to be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants