Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate Discord channel join/part messages relayed to Telegram #106

Open
prenetic opened this issue Apr 20, 2019 · 3 comments
Open

Inaccurate Discord channel join/part messages relayed to Telegram #106

prenetic opened this issue Apr 20, 2019 · 3 comments
Assignees
Labels
bug confirmed Bug has been confirmed

Comments

@prenetic
Copy link

prenetic commented Apr 20, 2019

This goes back to the original feature request (60). Currently, Discord join/part messages are being relayed, however depending on the Discord server's configuration they may be inaccurate.

For example, if someone joins a Discord server, but is not granted read permission to a channel that is linked between Discord and Telegram, then they have not actually joined that channel. Despite this, TediCross still relays to the Telegram side that someone has joined the Discord side of the chat. In actuality, this person needs to be granted read permission to the bridged channel before they will be able to even see it at all, let alone read any messages within.

Instead of relaying (potentially multiple) global Discord joins where many channels may be completely hidden from a new user's perspective, it would be more accurate to evaluate channel joins/parts based on read permission (or alternatively the per-channel member list) for each bridged room individually. This also has the added benefit of tracking and relaying channel parts when access to a given channel on the Discord side is revoked.

@Lulalaby Lulalaby self-assigned this Mar 9, 2023
@Lulalaby Lulalaby added the bug label Mar 9, 2023
@Lulalaby
Copy link
Collaborator

Lulalaby commented Mar 9, 2023

Issue Check

  • Can this issue be closed
  • Does this issue still needs attention

@prenetic
Copy link
Author

As far as I'm aware, this has not been addressed.

@Lulalaby
Copy link
Collaborator

Oky. Just trying to catching up as I took over maintaining.

@Lulalaby Lulalaby added confirmed Bug has been confirmed and removed checking labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed Bug has been confirmed
Projects
None yet
Development

No branches or pull requests

2 participants