Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Option not to show dropped instances in Top Clients list #902

Open
squromiv opened this issue Apr 10, 2024 · 2 comments
Open

[FR] Option not to show dropped instances in Top Clients list #902

squromiv opened this issue Apr 10, 2024 · 2 comments

Comments

@squromiv
Copy link

I set some flooding subnets to drop in Drop Requests App options.
screen_2024 04 10 001

And these IPs still exist as clients in the main Dashboard.
screen_2024 04 10 002
But they are really not my "clients". Also it is hard to understand whether they are already included in drop settings or not. I have to open Drop Requests App every time. It should be cool to hide info regarding ignored instances at all.

@ShreyasZare
Copy link
Member

Thanks for the request. This was added recently so that the dropped stats are shown in Dashboard to make it clear when the client is hitting the query rate limit. The Drop Request app uses same mechanism to drop and thus the stats counter is unable to distinguish between both the cases.

Will get that updated so that both the cases are handled differently to prevent the clients that are blocked using Drop Requests to be listed as clients.

@squromiv
Copy link
Author

squromiv commented Apr 10, 2024

Will get that updated so that both the cases are handled differently to prevent the clients that are blocked using Drop Requests to be listed as clients.

It will be awesome! Thanks a lot. Will be waiting for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants