Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Hamburger menu doesn't get dismissed on mobile when clicking item #163

Open
dgodongm opened this issue Sep 19, 2023 · 3 comments
Open
Assignees
Labels
bug Something isn't working needs triage Determine priority of issues

Comments

@dgodongm
Copy link
Contributor

dgodongm commented Sep 19, 2023

Hamburger menu doesn't get dismissed on mobile when clicking item. Selected page is opened, but underneath the menu.
Short video attached:

tih_hamburger.mov

Expected Behavior

Menu should close when clicking item

Current Behavior

Menu remains open

Possible Solution

Have not investigated code fix, but behavior change should be to dismiss/collapse menu

Steps to Reproduce

  1. On mobile or mobile sized viewport, go to https://www.techishiring.com/
  2. Click on Hamburger menu and click About (or other menu item)
@dgodongm dgodongm added bug Something isn't working needs triage Determine priority of issues labels Sep 19, 2023
@dgodongm
Copy link
Contributor Author

@chadstewart Ran across this when playing around with app. I'll try to poke around to investigate possible fix, but thought it might be worth capturing for now.

@dgodongm
Copy link
Contributor Author

@chadstewart Perhaps this might get addressed when #133 is done?

@dgodongm
Copy link
Contributor Author

It seems issue only happens with relative links. I noticed that the "Main Nav" molecule story doesn't have the issue so I updated the About link locally to point to https://www.google.com (like the "Main Nav" molecule story) and hamburger menu closes/collapses as expected. Doesn't get to root of issue, but at least better isolated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Determine priority of issues
Projects
None yet
Development

No branches or pull requests

2 participants