Contact Heading and Contact Form Refactor #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moving Box and VStack ChakraUI components.
|
Someone is attempting to deploy a commit to a Personal Account owned by @TechIsHiring on Vercel. @TechIsHiring first needs to authorize it. |
|
@chadstewart Almost done with this PR. I've noted a few things including no current replacement for the Spinner Component in the ShadCN UI. Is there an alternative that you were thinking for this? |
@chadstewart I created a custom spinner component in the meantime that could take it's place. This should be good to go and ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the removal of ChakraUI coming soon, I've refactored components that were on the Contact Heading Page and Contact Form Page to utilize tailwind classes for styling. Since these same components exist on other pages, I've also made sure that I wasn't impacting the other pages and any additional attributes that was added on the pages were accounted for. For example, the
Buttoncomponent can be displayed as a<a>or a<button>and theDefaultTextcomponent can be a<p>or a<span>.The following components have been refactored as a result.
Some of the components have default styling hardcoding that I took from the ChakraUI component's attributes (matched it as best as I could either using the direct values or using a tailwind class that was close in value). This could be changed or removed at a later time.
Note: This branch branches off of branch 133-set-up-shadcn. I will make sure that this branch is kept up to date with that parent branch. But regardless PR #164 will have to be merged into
devbefore this branch can be merged.Related Issue
Resolves: #134
Motivation and Context
Change is required due to the removal/deprecation of ChakraUI for this project.
How Has This Been Tested?
I tested visually through making sure the styling of the previous components matches exactly or closest to the old ChakraUI styling via tailwind classes. And went through to double check other pages that utilize the components that were refactored to make sure there weren't any styling or type issues.
Screenshots (if appropriate):
Incompatibility
The Spinner Component doesn't have an equivalent component in ShadCN UI's library. I created a customized solution for the spinner that could work. This could be replaced at a later time should a ShadCN UI equivalent come out.
Future Considerations
Some future considerations of refactoring, some which have been mentioned in #138
<p>and<span>HTML elements