Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error 1001, 1002 and 1003 #2915

Open
1 task done
DanielProg39 opened this issue Sep 7, 2023 · 105 comments
Open
1 task done

Error 1001, 1002 and 1003 #2915

DanielProg39 opened this issue Sep 7, 2023 · 105 comments
Labels
bug Something isn't working

Comments

@DanielProg39
Copy link

Official Instance

Describe the bug

I opened this video and got a message saying: "Failed with error code 1001, see logs for more info". Other videos play properly without any issues.

To Reproduce

  1. Open this video.
  2. Observe an error.

Expected behavior

Video should play like any other.

Logs/Errors

Found this in logs:

Error: Shaka Error
    at new x (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:22884)
    at nm (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:389839)
    at Vy.h (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:391259)
    at Cr (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:4167)
    at Hy.next (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:4465)
    at t (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:4694)

Can provide more logs if required

Browser, and OS with Version.

Brave 1.57.62 on Chromium 116.0.5845.180

Additional context

No response

@DanielProg39 DanielProg39 added the bug Something isn't working label Sep 7, 2023
@ReshmaM8
Copy link

(When I click on your video I get error 1002; there are other videos in my feed also encounter error 1002 as well. Yet some videos play fine. I joined few hours ago on Chrome 116.0.5845.180 with duckduckgo search engine

@DanielProg39
Copy link
Author

Now the video is playing fine for me, no errors. @ReshmaM8 let us know when there are no errors, until then I'll leave the issue open.

@DanielProg39 DanielProg39 changed the title Error 1001 Error 1001 and 1002 Sep 11, 2023
@ReshmaM8
Copy link

I have inconsistent response when I try to play this video: Link
I played first on my main chrome profile and it works but when I opened a guest profile , go to piped.video -> search this video and hit play I get error code 1002.
image
I have two .har network logs - one when the video did load and one with the error code; should I attach them(sensitive info redacted using google HAR analyzer) here or do I send it to specifically to an email ?

@FireMasterK
Copy link
Member

You can send it to kavin@kavin.rocks, I'll have a look!

@oneover0
Copy link

are you facing this issue still? i am getting this same error in every video .

@ReshmaM8
Copy link

yeah, I'm having the same issue. The network traffic shows the video playback in a cycle of cancelled -> 500 --> one 200 request --> pending.

@DanielProg39
Copy link
Author

Now the video is playing fine for me, no errors.

Not anymore. Now I get misterious Error 1002 for the video I reported in the first place.

Here's new error log in stack:

Error: Shaka Error
    at new x (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:22884)
    at Vy.h (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:391198)
    at Cr (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:4167)
    at Hy.throw (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:4560)
    at n (https://piped.video/assets/shaka-player.ui-92211a3f.js:1:4730)

@EHP4321
Copy link

EHP4321 commented Sep 15, 2023

Having the same problem. Getting 1002 error. Sometimes just changing instance works. But once a video fails on a specific instance it keeps failing on that instance, but switching to another video generally works. So maybe there is a cache issue.
Edit: Actually It seems switching instance always works.
Edit 2: Nope looks like I was just lucky a few times

@opusforlife2
Copy link
Contributor

Apart from Error 1002, I've also seen 1003 several times.

@DanielProg39 DanielProg39 changed the title Error 1001 and 1002 Error 1001, 1002 and 1003 Sep 21, 2023
@DanielProg39
Copy link
Author

Now the video is playing fine for me, no errors.

Again. Got no errors

@saenglert
Copy link

The bug appears to be cause by missing cors headers in the http response: #2970 (comment)

@DanielProg39
Copy link
Author

The bug appears to be cause by missing cors headers in the http response: #2970 (comment)

I've noticed CORS errors many times in the past in plenty videos, though they led to video starting playing later than usual or load for a long time, they haven't let to any errors displayed.

@DanielProg39
Copy link
Author

Again. Got no errors

Checked the video out once more. Error 1002.

"Error: Shaka Error 1002
    at new x (https://piped.video/assets/shaka-player.ui-7171c67c.js:1:22922)
    at Hy.h (https://piped.video/assets/shaka-player.ui-7171c67c.js:1:391789)
    at Mr (https://piped.video/assets/shaka-player.ui-7171c67c.js:1:4167)
    at qy.throw (https://piped.video/assets/shaka-player.ui-7171c67c.js:1:4560)
    at n (https://piped.video/assets/shaka-player.ui-7171c67c.js:1:4730)"

@saenglert
Copy link

The bug appears to be cause by missing cors headers in the http response: #2970 (comment)

I've noticed CORS errors many times in the past in plenty videos, though they led to video starting playing later than usual or load for a long time, they haven't let to any errors displayed.

grafik

Well, if you look at the error object, you can see it is caused by the network error. And the network error is caused by the connection not completing because of the missing cors header.

@opusforlife2
Copy link
Contributor

I got a 1002 on the Syncpundit instance as well, but only once, and a reload fixed it immediately.

@saenglert
Copy link

kavin.rocks now returns the proper headers and I no longer receive the error.

image

@DanielProg39
Copy link
Author

Everything seems to be back to normal. I'm not getting any errors and no CORS errors, although the video was loading endlessly. After reloading the page several times and setting the playback indicator to the beginning of the video, the video started playing and played to the end without any problems. I suspect this was something to do with the cache.

Overall, the issue seems to have been resolved. I'm going to keep it open for a while in case anyone else is still experiencing these errors. So if you got them in any videos, check them now and report if any of them still seem to be broken.

@ghost
Copy link

ghost commented Sep 27, 2023

@DanielProg39 can you check this https://piped.video/watch?v=oRdxUFDoQe0 ?
For me, its giving 1001 error

@DanielProg39
Copy link
Author

@DanielProg39 can you check this https://piped.video/watch?v=oRdxUFDoQe0 ? For me, its giving 1001 error

Strangely, I got no errors or problems. The whole video played perfectly

@ReshmaM8
Copy link

@DanielProg39 can you check this https://piped.video/watch?v=oRdxUFDoQe0 ? For me, its giving 1001 error

I checked as well, no issues (chrome, win 10)
other videos are playing for me as well - just at the beginning it takes a while to load cause the video playback fails a couple of times before succeeding

@ghost
Copy link

ghost commented Sep 28, 2023

@DanielProg39 @ReshmaM8
Actually the problem was from ISP😅. When i switched isp to telecom one, it works fine.
Thanks

@opusforlife2
Copy link
Contributor

Still had some 1002's yesterday. Had to switch back and forth between instances to be able to watch the intended videos.

@ghost
Copy link

ghost commented Oct 3, 2023

1002 here. happens all the time on almost all instances.

@AlyoshaVasilieva
Copy link
Contributor

In config/pipedapi.conf, adding:

        sub_filter '&ump=1' '';
        sub_filter_once off;
        sub_filter_types application/json;

inside the location / { block seems to successfully strip UMP from stream URLs.

@nanedi
Copy link

nanedi commented Mar 31, 2024

Experiencing 1002s on every single video I've tried on piped.video. The comments are also displaying like this:

a bunch of comments that say "null"

I'm not sure how much of this will be relevant for you, but here's everything in my console (using this video as an example, but like I said, this happens on every single video I've tried to watch today):

EmeEncryptionSchemePolyfill: Waiting to detect encryptionScheme support. shaka-player.ui-vTahH29n.js:1:554197
McEncryptionSchemePolyfill: Waiting to detect encryptionScheme support. shaka-player.ui-vTahH29n.js:1:555909
[trimmed because it seems to be a repeat of the below from "TypeError" to "index]
TypeError: D is null
    v https://piped.video/assets/index-6WWQy-Nd.js:8
    r https://piped.video/assets/index-6WWQy-Nd.js:8
    effect https://piped.video/assets/index-6WWQy-Nd.js:3
    run https://piped.video/assets/index-6WWQy-Nd.js:3
    get value https://piped.video/assets/index-6WWQy-Nd.js:3
    o https://piped.video/assets/index-6WWQy-Nd.js:8
    effect https://piped.video/assets/index-6WWQy-Nd.js:3
    run https://piped.video/assets/index-6WWQy-Nd.js:3
    get value https://piped.video/assets/index-6WWQy-Nd.js:3
    i https://piped.video/assets/index-6WWQy-Nd.js:8
    effect https://piped.video/assets/index-6WWQy-Nd.js:3
    run https://piped.video/assets/index-6WWQy-Nd.js:3
    get value https://piped.video/assets/index-6WWQy-Nd.js:3
    get https://piped.video/assets/index-6WWQy-Nd.js:3
    setup https://piped.video/assets/index-6WWQy-Nd.js:8
    Io https://piped.video/assets/index-6WWQy-Nd.js:4
    V https://piped.video/assets/index-6WWQy-Nd.js:4
    run https://piped.video/assets/index-6WWQy-Nd.js:3
    update https://piped.video/assets/index-6WWQy-Nd.js:4
    ve https://piped.video/assets/index-6WWQy-Nd.js:4
    Pe https://piped.video/assets/index-6WWQy-Nd.js:4
    re https://piped.video/assets/index-6WWQy-Nd.js:4
    I https://piped.video/assets/index-6WWQy-Nd.js:4
    $ https://piped.video/assets/index-6WWQy-Nd.js:4
    w https://piped.video/assets/index-6WWQy-Nd.js:4
    C https://piped.video/assets/index-6WWQy-Nd.js:4
    I https://piped.video/assets/index-6WWQy-Nd.js:4
    $ https://piped.video/assets/index-6WWQy-Nd.js:4
    w https://piped.video/assets/index-6WWQy-Nd.js:4
    C https://piped.video/assets/index-6WWQy-Nd.js:4
    I https://piped.video/assets/index-6WWQy-Nd.js:4
    $ https://piped.video/assets/index-6WWQy-Nd.js:4
    w https://piped.video/assets/index-6WWQy-Nd.js:4
    C https://piped.video/assets/index-6WWQy-Nd.js:4
    I https://piped.video/assets/index-6WWQy-Nd.js:4
    $ https://piped.video/assets/index-6WWQy-Nd.js:4
    w https://piped.video/assets/index-6WWQy-Nd.js:4
    C https://piped.video/assets/index-6WWQy-Nd.js:4
    I https://piped.video/assets/index-6WWQy-Nd.js:4
    V https://piped.video/assets/index-6WWQy-Nd.js:4
    run https://piped.video/assets/index-6WWQy-Nd.js:3
    update https://piped.video/assets/index-6WWQy-Nd.js:4
    ve https://piped.video/assets/index-6WWQy-Nd.js:4
    Pe https://piped.video/assets/index-6WWQy-Nd.js:4
    re https://piped.video/assets/index-6WWQy-Nd.js:4
    I https://piped.video/assets/index-6WWQy-Nd.js:4
    $ https://piped.video/assets/index-6WWQy-Nd.js:4
    H https://piped.video/assets/index-6WWQy-Nd.js:4
    I https://piped.video/assets/index-6WWQy-Nd.js:4
    $ https://piped.video/assets/index-6WWQy-Nd.js:4
    w https://piped.video/assets/index-6WWQy-Nd.js:4
    C https://piped.video/assets/index-6WWQy-Nd.js:4
    I https://piped.video/assets/index-6WWQy-Nd.js:4
    Q https://piped.video/assets/index-6WWQy-Nd.js:4
    H https://piped.video/assets/index-6WWQy-Nd.js:4
    I https://piped.video/assets/index-6WWQy-Nd.js:4
    Q https://piped.video/assets/index-6WWQy-Nd.js:4
    k https://piped.video/assets/index-6WWQy-Nd.js:4
    C https://piped.video/assets/index-6WWQy-Nd.js:4
    I https://piped.video/assets/index-6WWQy-Nd.js:4
    V https://piped.video/assets/index-6WWQy-Nd.js:4
    run https://piped.video/assets/index-6WWQy-Nd.js:3
    update https://piped.video/assets/index-6WWQy-Nd.js:4
    zt https://piped.video/assets/index-6WWQy-Nd.js:4
    dc https://piped.video/assets/index-6WWQy-Nd.js:4
index-6WWQy-Nd.js:4:587
EmeEncryptionSchemePolyfill: Already installed. shaka-player.ui-vTahH29n.js:1:554003
McEncryptionSchemePolyfill: Already installed. shaka-player.ui-vTahH29n.js:1:555772
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://pipedproxy-cwl.kavin.rocks/videoplayback?aitags=133%2C134%2C135%2C136%2C160%2C242%2C243%2C244%2C247%2C278%2C298%2C299%2C302%2C303%2C394%2C395%2C396%2C397%2C398%2C399&c=WEB&clen=20638403&cpn=bvvsL8UsYb1xvAEX&dur=931.320&ei=mG8IZvPrJPiqxN8Pmf6mcA&expire=1711850488&fexp=51141542&fvip=1&gir=yes&host=rr2---sn-5hne6nzy.googlevideo.com&id=o-AJsFE67vt6NP7yf0m4jGuQFcnulrROyU4EUV1dIwRLX2&initcwndbps=2331250&ip=194.110.13.94&itag=135&keepalive=yes&lmt=1688588138330052&lsig=ALClDIEwRAIgTpNeTULJIkXHKHYBkOvD_FXYhe6r4TRbgYBa8TCkc10CIFFjduw8_GerLy9MRrQkZPMKRir8-QcXM92cUmSL0ot2&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&mh=bE&mime=video%2Fmp4&mm=31%2C26&mn=sn-5hne6nzy%2Csn-4g5edn6k&ms=au%2Conr&mt=1711828611&mv=m&mvi=2&n=bsnB1G0ZHUA3xA&ns=ljO6bdXCcZ9Cz8jiuJIObdsQ&pl=24&qhash=ba7adbf7&requiressl=yes&sefc=1&sig=AJfQdSswRAIgVSd5DeIxP8Z-VygolNuVywkZur2H8lzandU1m_6m_IACIFGn_67PoKPpVCqzLidJIdEq1ul0rZ8xNhVO6zx2-ruV&source=youtube&sparams=expire%2Cei%2Cip%2Cid%2Caitags%2Csource%2Crequiressl%2Cxpc%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cns%2Cgir%2Cclen%2Cdur%2Clmt&spc=UWF9f_efeVWvG8HvhXq8auqqsNLXDmvuc9fV09WwRA9eFzY&svpuc=1&txp=5535434&ump=1&vprv=1&xpc=EgVo2aDSNQ%3D%3D&range=741-2860. (Reason: CORS request did not succeed). Status code: (null).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://pipedproxy-cwl.kavin.rocks/videoplayback?c=WEB&clen=5893922&cpn=bvvsL8UsYb1xvAEX&dur=931.321&ei=mG8IZvPrJPiqxN8Pmf6mcA&expire=1711850488&fexp=51141542&fvip=1&gir=yes&host=rr2---sn-5hne6nzy.googlevideo.com&id=o-AJsFE67vt6NP7yf0m4jGuQFcnulrROyU4EUV1dIwRLX2&initcwndbps=2331250&ip=194.110.13.94&itag=249&keepalive=yes&lmt=1688583208003113&lsig=ALClDIEwRAIgTpNeTULJIkXHKHYBkOvD_FXYhe6r4TRbgYBa8TCkc10CIFFjduw8_GerLy9MRrQkZPMKRir8-QcXM92cUmSL0ot2&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&mh=bE&mime=audio%2Fwebm&mm=31%2C26&mn=sn-5hne6nzy%2Csn-4g5edn6k&ms=au%2Conr&mt=1711828611&mv=m&mvi=2&n=bsnB1G0ZHUA3xA&ns=ljO6bdXCcZ9Cz8jiuJIObdsQ&pl=24&qhash=ef39bf3a&requiressl=yes&sefc=1&sig=AJfQdSswRgIhAMbfjX1W7NhUsQDB2HSp0ZpbgaBQM4DphAT6niPAFv9xAiEAwdAXeHeQHJpQptxpMKOvdOkXfFBtnVqvoBhGMC1rJk8%3D&source=youtube&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cxpc%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cns%2Cgir%2Cclen%2Cdur%2Clmt&spc=UWF9f_efeVWvG8HvhXq8auqqsNLXDmvuc9fV09WwRA9eFzY&svpuc=1&txp=5532434&ump=1&vprv=1&xpc=EgVo2aDSNQ%3D%3D&range=0-258. (Reason: CORS request did not succeed). Status code: (null).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://pipedproxy-cwl.kavin.rocks/videoplayback?c=WEB&clen=5893922&cpn=bvvsL8UsYb1xvAEX&dur=931.321&ei=mG8IZvPrJPiqxN8Pmf6mcA&expire=1711850488&fexp=51141542&fvip=1&gir=yes&host=rr2---sn-5hne6nzy.googlevideo.com&id=o-AJsFE67vt6NP7yf0m4jGuQFcnulrROyU4EUV1dIwRLX2&initcwndbps=2331250&ip=194.110.13.94&itag=249&keepalive=yes&lmt=1688583208003113&lsig=ALClDIEwRAIgTpNeTULJIkXHKHYBkOvD_FXYhe6r4TRbgYBa8TCkc10CIFFjduw8_GerLy9MRrQkZPMKRir8-QcXM92cUmSL0ot2&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&mh=bE&mime=audio%2Fwebm&mm=31%2C26&mn=sn-5hne6nzy%2Csn-4g5edn6k&ms=au%2Conr&mt=1711828611&mv=m&mvi=2&n=bsnB1G0ZHUA3xA&ns=ljO6bdXCcZ9Cz8jiuJIObdsQ&pl=24&qhash=ef39bf3a&requiressl=yes&sefc=1&sig=AJfQdSswRgIhAMbfjX1W7NhUsQDB2HSp0ZpbgaBQM4DphAT6niPAFv9xAiEAwdAXeHeQHJpQptxpMKOvdOkXfFBtnVqvoBhGMC1rJk8%3D&source=youtube&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cxpc%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cns%2Cgir%2Cclen%2Cdur%2Clmt&spc=UWF9f_efeVWvG8HvhXq8auqqsNLXDmvuc9fV09WwRA9eFzY&svpuc=1&txp=5532434&ump=1&vprv=1&xpc=EgVo2aDSNQ%3D%3D&range=259-1852. (Reason: CORS request did not succeed). Status code: (null).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://pipedproxy-cwl.kavin.rocks/videoplayback?aitags=133%2C134%2C135%2C136%2C160%2C242%2C243%2C244%2C247%2C278%2C298%2C299%2C302%2C303%2C394%2C395%2C396%2C397%2C398%2C399&c=WEB&clen=20638403&cpn=bvvsL8UsYb1xvAEX&dur=931.320&ei=mG8IZvPrJPiqxN8Pmf6mcA&expire=1711850488&fexp=51141542&fvip=1&gir=yes&host=rr2---sn-5hne6nzy.googlevideo.com&id=o-AJsFE67vt6NP7yf0m4jGuQFcnulrROyU4EUV1dIwRLX2&initcwndbps=2331250&ip=194.110.13.94&itag=135&keepalive=yes&lmt=1688588138330052&lsig=ALClDIEwRAIgTpNeTULJIkXHKHYBkOvD_FXYhe6r4TRbgYBa8TCkc10CIFFjduw8_GerLy9MRrQkZPMKRir8-QcXM92cUmSL0ot2&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&mh=bE&mime=video%2Fmp4&mm=31%2C26&mn=sn-5hne6nzy%2Csn-4g5edn6k&ms=au%2Conr&mt=1711828611&mv=m&mvi=2&n=bsnB1G0ZHUA3xA&ns=ljO6bdXCcZ9Cz8jiuJIObdsQ&pl=24&qhash=ba7adbf7&requiressl=yes&sefc=1&sig=AJfQdSswRAIgVSd5DeIxP8Z-VygolNuVywkZur2H8lzandU1m_6m_IACIFGn_67PoKPpVCqzLidJIdEq1ul0rZ8xNhVO6zx2-ruV&source=youtube&sparams=expire%2Cei%2Cip%2Cid%2Caitags%2Csource%2Crequiressl%2Cxpc%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cns%2Cgir%2Cclen%2Cdur%2Clmt&spc=UWF9f_efeVWvG8HvhXq8auqqsNLXDmvuc9fV09WwRA9eFzY&svpuc=1&txp=5535434&ump=1&vprv=1&xpc=EgVo2aDSNQ%3D%3D&range=741-2860. (Reason: CORS request did not succeed). Status code: (null).
Object { severity: 2, category: 1, code: 1002, data: (3) […], handled: false, message: "Shaka Error 1002", stack: "I@https://piped.video/assets/shaka-player.ui-vTahH29n.js:1:23822\nu2/<@https://piped.video/assets/shaka-player.ui-vTahH29n.js:1:437516\nlo@https://piped.video/assets/shaka-player.ui-vTahH29n.js:1:4335\ncE/this.throw@https://piped.video/assets/shaka-player.ui-vTahH29n.js:1:4728\nn@https://piped.video/assets/shaka-player.ui-vTahH29n.js:1:4893\n" }
WatchVideo-CZ3GI6y4.js:3:10758

The same issue here.

@stonerl
Copy link

stonerl commented Mar 31, 2024

In config/pipedapi.conf, adding:

        sub_filter '&ump=1' '';
        sub_filter_once off;
        sub_filter_types application/json;

inside the location / { block seems to successfully strip UMP from stream URLs.

Can confirm that this is working.

@tonytonyistony
Copy link

In config/pipedapi.conf, adding:

        sub_filter '&ump=1' '';
        sub_filter_once off;
        sub_filter_types application/json;

inside the location / { block seems to successfully strip UMP from stream URLs.

Can confirm that this is working.

Confirmed as well.

@ngn13
Copy link

ngn13 commented Mar 31, 2024

In config/pipedapi.conf, adding:

        sub_filter '&ump=1' '';
        sub_filter_once off;
        sub_filter_types application/json;

inside the location / { block seems to successfully strip UMP from stream URLs.

Can confirm that this is working.

Confirmed as well.

Can confirm too

@nanedi
Copy link

nanedi commented Mar 31, 2024

In config/pipedapi.conf, adding:

        sub_filter '&ump=1' '';
        sub_filter_once off;
        sub_filter_types application/json;

inside the location / { block seems to successfully strip UMP from stream URLs.

On web yes its working, but on libretube it stopped wotking.

@ngn13
Copy link

ngn13 commented Mar 31, 2024

In config/pipedapi.conf, adding:

        sub_filter '&ump=1' '';
        sub_filter_once off;
        sub_filter_types application/json;

inside the location / { block seems to successfully strip UMP from stream URLs.

On web yes its working, but on libretube it stopped wotking.

Yeah, it seems to break libretube

@stonerl
Copy link

stonerl commented Mar 31, 2024

@nanedi I'm using Yattee on iOS, and it's working perfectly fine. Before the fix, I had the same issue as I had on the web frontend. Now all the videos are playing again.

@maximushugus
Copy link

In config/pipedapi.conf, adding:

        sub_filter '&ump=1' '';
        sub_filter_once off;
        sub_filter_types application/json;

inside the location / { block seems to successfully strip UMP from stream URLs.

Can also confirm that my self hosted instance is working again.

Yeah, it seems to break libretube

I managed to make libretube to work with this modification by using HLS instead of DASH

@ngn13
Copy link

ngn13 commented Mar 31, 2024

if ($http_user_agent !~ "com.github.libretube") {
    set $ump '&ump=1';
}

sub_filter_once off;
sub_filter $ump '';
sub_filter_types application/json;

fix for libretube

@nanedi
Copy link

nanedi commented Mar 31, 2024

if ($http_user_agent !~ "com.github.libretube") {
    set $ump '&ump=1';
}

sub_filter_once off;
sub_filter $ump '';
sub_filter_types application/json;

fix for libretube

Fixed it,

Thanks

@nanedi
Copy link

nanedi commented Mar 31, 2024

if ($http_user_agent !~ "com.github.libretube") {
    set $ump '&ump=1';
}

sub_filter_once off;
sub_filter $ump '';
sub_filter_types application/json;

fix for libretube

But libretube still get error 1002.

@agpsl
Copy link

agpsl commented Mar 31, 2024

I didn't use any of the fixes suggested in this issue (for now) and Libretube (using my self hosted instance) is working just fine with HLS enabled - just reporting

@ngn13
Copy link

ngn13 commented Mar 31, 2024

if ($http_user_agent !~ "com.github.libretube") {
    set $ump '&ump=1';
}

sub_filter_once off;
sub_filter $ump '';
sub_filter_types application/json;

fix for libretube

But libretube still get error 1002.

Do you also get 1002 on the web?

@nanedi
Copy link

nanedi commented Mar 31, 2024

if ($http_user_agent !~ "com.github.libretube") {
    set $ump '&ump=1';
}

sub_filter_once off;
sub_filter $ump '';
sub_filter_types application/json;

fix for libretube

But libretube still get error 1002.

Do you also get 1002 on the web?

Web is fine.

@ngn13
Copy link

ngn13 commented Mar 31, 2024

idk it works for me, I dont get 1002 on libretube with the fix, try using HLS like @maximushugus and @ @agpsl pointed out
you can enable it from settings > audio and video > use hls

@nanedi
Copy link

nanedi commented Mar 31, 2024

idk it works for me, I dont get 1002 on libretube with the fix, try using HLS like @maximushugus and @ @agpsl pointed out you can enable it from settings > audio and video > use hls

Yes I understand that dash.

@lietu
Copy link

lietu commented Apr 2, 2024

Pulling latest container images and restarting my piped seems to have finally fixed the issues, thanks!

@nanedi
Copy link

nanedi commented Apr 2, 2024

Pulling latest container images and restarting my piped seems to have finally fixed the issues, thanks!

on the web, yes, on the libretube still get error 1002.

@lietu
Copy link

lietu commented Apr 2, 2024

As far as I can tell this is Piped and LibreTube is https://github.com/libre-tube/LibreTube/issues

@samip5
Copy link

samip5 commented Apr 3, 2024

Please everyone affected with 1002, just re-pull your container(s) and restart it.
It might need some forcing for it to pull the newer one.

If your ytproxy is not sending the following headers (/videoplayback endpoint):

access-control-allow-headers: *
access-control-allow-methods: *
access-control-allow-origin: *

Then you're not running latest enough.

@Scorpoon
Copy link

Scorpoon commented Apr 4, 2024

Hadn't any issues since the last container update. Thank you ;)

@Bnyro Bnyro pinned this issue Apr 5, 2024
@amirianos
Copy link

Now I have the same issue here

@jiaen-p
Copy link

jiaen-p commented May 13, 2024

I use the libretube app with a self hosted piped instance, and i've noticed that dash is disabled, so I've dived into the code and this is what I have found in regards to dash/hls

From what I can see is that newpipe extractor defaults to hls except for livestream, they set the properties here.

public static final class Builder {
        private String id;
        private String content;
        private boolean isUrl;
        private DeliveryMethod deliveryMethod = DeliveryMethod.PROGRESSIVE_HTTP;
        @Nullable
        private MediaFormat mediaFormat;
        @Nullable
        private String manifestUrl;
        // Use of the Boolean class instead of the primitive type needed for setter call check
        private Boolean isVideoOnly;
        private String resolution;
        @Nullable
        private ItagItem itagItem;

        /**
         * Create a new {@link Builder} instance with its default values.
         */
        public Builder() {
        }

There's a method in which you can set the delivery method in the same class

 /**
         * Set the {@link DeliveryMethod} of the {@link VideoStream}.
         *
         * <p>
         * It must not be null.
         * </p>
         *
         * <p>
         * The default delivery method is {@link DeliveryMethod#PROGRESSIVE_HTTP}.
         * </p>
         *
         * @param deliveryMethod the {@link DeliveryMethod} of the {@link VideoStream}, which must
         *                       not be null
         * @return this {@link Builder} instance
         */
        public Builder setDeliveryMethod(@Nonnull final DeliveryMethod deliveryMethod) {
            this.deliveryMethod = deliveryMethod;
            return this;
        }

From what I can gather, the piped backend requests the stream info from here you can call on that method to set the stream type

                if (!livestream) {
            info.getVideoOnlyStreams().forEach(stream -> videoStreams.add(new PipedStream(stream.getItag(), rewriteVideoURL(stream.getContent(), extraParams),
                    String.valueOf(stream.getFormat()), stream.getResolution(), stream.getFormat().getMimeType(), true,
                    stream.getBitrate(), stream.getInitStart(), stream.getInitEnd(), stream.getIndexStart(),
                    stream.getIndexEnd(), stream.getCodec(), stream.getWidth(), stream.getHeight(), stream.getFps(), stream.getItagItem().getContentLength())));
            info.getVideoStreams()
                    .forEach(stream -> videoStreams
                            .add(new PipedStream(stream.getItag(), rewriteVideoURL(stream.getContent(), Map.of()), String.valueOf(stream.getFormat()),
                                    stream.getResolution(), stream.getFormat().getMimeType(), false, stream.getItagItem().getContentLength())));

            info.getAudioStreams()
                    .forEach(stream -> audioStreams.add(new PipedStream(stream.getItag(), rewriteVideoURL(stream.getContent(), extraParams),
                            String.valueOf(stream.getFormat()), stream.getAverageBitrate() + " kbps",
                            stream.getFormat().getMimeType(), false, stream.getBitrate(), stream.getInitStart(),
                            stream.getInitEnd(), stream.getIndexStart(), stream.getIndexEnd(), stream.getItagItem().getContentLength(), stream.getCodec(), stream.getAudioTrackId(),
                            stream.getAudioTrackName(), Optional.ofNullable(stream.getAudioTrackType()).map(Enum::name).orElse(null),
                            Optional.ofNullable(stream.getAudioLocale()).map(Locale::toLanguageTag).orElse(null)
                    )));
        }
        final Map<String, String> extraParams = Map.of(
//                "ump", "1",
//                "srfvp", "1"
        );

I think the bug is somewhere in the newpipe deliveryMethod, the stream builder expects a single value in the delivery method and piped is passing 2.

However, I'm not an familiar with Java, and I hope I could contribute to the project.
Cheers.

@samip5
Copy link

samip5 commented May 19, 2024

Now I have the same issue here

In my experience, the error (1001 as an example) seems to happen on just some channels, possibly related to the type of video being used there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests