Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent automatic refresh after a new build #1199

Open
1 task done
lbrdt opened this issue Jul 11, 2022 · 6 comments · May be fixed by #2574
Open
1 task done

Prevent automatic refresh after a new build #1199

lbrdt opened this issue Jul 11, 2022 · 6 comments · May be fixed by #2574
Labels
bug Something isn't working P1

Comments

@lbrdt
Copy link

lbrdt commented Jul 11, 2022

Official Instance

Describe the bug

When a new build is finished, new static resources are generated. So when Piped tries to sync with the newly built resources, it refreshes the page automatically without warning. Sometimes when you're watching the video. There needs to be a warning prompt to allow user to refresh when it is convenient.

To Reproduce

  1. Visit a piped instance watch some videos for it to cache its resource in the browser.
  2. Start a build wwith a new commit is merged
  3. Go to the Piped instance
  4. Try waiting a while or view a video
  5. The page refreshes on it's own

Expected behavior

A litle prompt to allow user to refresh at their convenience

Logs/Errors

No logs

Browser, and OS with Version.

Chromium Browsers
FIrefox Mobile

Additional context

It happens on both desktop and mobile browser

@lbrdt lbrdt added the bug Something isn't working label Jul 11, 2022
@lima46zulu
Copy link

I had the same behavior on the feed page -- when that page was working. All the screenshots on my feed would load, then right away the page would reload as I was about to click on a video. It never happened to me while watching a video ... but it's still very annoying.

@opusforlife2
Copy link
Contributor

As discussed with Kavin on IRC: the way Element Web does it seems good. It shows a small notification in the corner alerting the user to a new update. It offers an Update button, which reloads the web app, as well as Dismiss.

@lima46zulu
Copy link

@opusforlife2 That is not the current behaviour on iPad OS (Chrome). Sometimes, not all ways, when I go to piped the page first loads. Then it automatically reloads ... and will continue to reload every few seconds or so. In other words the site is unusable when this happens. I have never noticed the notification button (I don't have my iPad handy), but the page just reloads on its own.

@opusforlife2
Copy link
Contributor

It doesn't seem like you read the comment fully? I'm talking about Element Web.

@moriel5
Copy link

moriel5 commented Nov 12, 2023

I was wondering why the first time every time I opened Piped after clearing cache and cookies (I had set this to automatically occur upon browser close), it would refresh after a few minutes, regardless of what I am doing (this often happens to me while watching a video, like just now, when it refreshed the page when I was 1 minute and 43 seconds into the video).

@moriel5
Copy link

moriel5 commented Nov 12, 2023

@opusforlife2 I agree, also Telegram and WhatsApp (not a WhatsApp user, but my family are) so something similar, where they offer a static overlay "Update Now" button to refresh (no option to dismiss).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants