Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update import imp to inportlib #2317

Closed
wants to merge 1 commit into from
Closed

update import imp to inportlib #2317

wants to merge 1 commit into from

Conversation

hunterzero99
Copy link

Description

Bump imp to importlib

Screenshot

Include screenshots if the changes are UI-related.

Issues Fixed or Closed

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods

@github-actions GitHub Actions
Copy link

Pull requests must be made to the nightly branch. Thanks.

@hunterzero99 hunterzero99 reopened this Apr 30, 2024
@hunterzero99 hunterzero99 changed the base branch from master to nightly April 30, 2024 22:32
@JonnyWong16
Copy link
Contributor

Do not modify any of the vendored packages inside the lib folder.

The proper way to address Python 3.12 is to remove all the Python 2 compatibility code per #2098.

@hunterzero99 hunterzero99 deleted the importlib branch April 30, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import imp fails in Python 3.12 replace with importlib
2 participants
@hunterzero99 @JonnyWong16