Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@change, and other @ tags, needlessly carried over to merged sentences #3088

Open
morbrorper opened this issue Nov 17, 2023 · 3 comments
Open
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.

Comments

@morbrorper
Copy link

morbrorper commented Nov 17, 2023

If a sentence that has a @change tag is changed, and the change results in a merge with another sentence, the tag is copied to the remaining sentence. This leads to a confusing state that can only be corrected by the owner of the tag, if they happen to notice, or an admin.

Of course, this applies to all @ tags, such as @needs_native_check.

Suggested solution: Make Horus exclude tags prefixed with "@" in copying tags when merging sentences.

I've deliberately labelled this a bug, even though Horus is just doing its job, as I consider it a bug in how Tatoeba works.

@morbrorper morbrorper added the bug Issue that describes a problem with a feature that doesn't work as expected. label Nov 17, 2023
@morbrorper morbrorper changed the title Horus copies @change, and other @ tags, to merged sentences @change, and other @ tags, needlessly carried over to merged sentences Nov 17, 2023
@ckjpn
Copy link

ckjpn commented Dec 6, 2023

Related: #2595
It's closed

See AndiPersti commented on Dec 17, 2020

@morbrorper
Copy link
Author

Related: #2595 It's closed

Yes, related, but not identical, as this only concerns special tags, prefixed with "@".

@ckjpn
Copy link

ckjpn commented Dec 8, 2023

AndiPersti's comment further refers to this comment on another issue that is related.

#1830 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Projects
None yet
Development

No branches or pull requests

2 participants