Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer message with redirection of tags in the advanced search #3050

Open
Guybrush88 opened this issue Apr 11, 2023 · 0 comments · May be fixed by #3051
Open

Clearer message with redirection of tags in the advanced search #3050

Guybrush88 opened this issue Apr 11, 2023 · 0 comments · May be fixed by #3051
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.

Comments

@Guybrush88
Copy link

Story or Context

I wanted to translate some English sentences from the Tanaka Corpus into Italian using this query: https://tatoeba.org/en/sentences/search?from=eng&has_audio=&native=&orphans=no&query=&sort_reverse=&tags=tanaka+corpus&to=&trans_filter=exclude&trans_has_audio=&trans_link=&trans_orphan=&trans_to=ita&trans_unapproved=&trans_user=&unapproved=no&user=&sort=words and I put 'tanaka corpus' (without quotes and everything in lower case) as the tag contained in the sentences I wanted to translate.
After the query started, I got this error message:

Warning: the following criteria have been ignored:

“tagged as tanaka corpus”, because it's an invalid tag name

However, I still received the proper sentences since they contain the proper tag, that is 'Tanaka Corpus', so here the proper capital letters of the tag are included and the advanced search recognized my initial input of the tag

Idea

The error message should be reworked, since the original query is still done, and the tag isn't actually ignored.

@Guybrush88 Guybrush88 added the enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. label Apr 11, 2023
@vinkaks vinkaks linked a pull request Apr 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant