Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the dict response in load_existing_datasets with a Pydantic class #85

Open
JackHopkins opened this issue Nov 24, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@JackHopkins
Copy link
Contributor

We should avoid passing loosely typed dictionaries around if we can avoid it. This should be replaced by a Pydantic class.

Note: This is in BufferedLogger.

@JackHopkins JackHopkins added the good first issue Good for newcomers label Nov 24, 2023
@cosmastech
Copy link
Contributor

Hi! I'm pretty new to Python and was looking for good first issues to tackle.

Was curious to know why you would use a Pydantic class here rather than a simple dataclass for this?

NotAdityaPawar added a commit to NotAdityaPawar/monkeypatch.py that referenced this issue Nov 24, 2023
@JackHopkins
Copy link
Contributor Author

Hey @cosmastech, a simple dataclass could work just as well!

If you're looking to contribute - awesome! I can create a couple of issues that are good starter issues to get to grips with the codebase.

I'll tag you in them when I've put them up.

@cosmastech
Copy link
Contributor

Hey @cosmastech, a simple dataclass could work just as well!

If you're looking to contribute - awesome! I can create a couple of issues that are good starter issues to get to grips with the codebase.

I'll tag you in them when I've put them up.

Cool! Thanks.

@JackHopkins
Copy link
Contributor Author

Could you please have a look at this one? @cosmastech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants