Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config setting to overwrite http/https prefix on return adress #49

Open
mangosd1337 opened this issue Aug 17, 2020 · 3 comments
Open
Labels
Invalid Seems like a Non-issue Request New Feature Request

Comments

@mangosd1337
Copy link

It would be a good idea to have a setting to always return the https prefix even when the application is running with the "secure": false setting.
If you run Nginx as a reverse proxy to handle the HTTPS stuff for you and run the actual app in HTTP mode, you get a link prefixed with http, even though your actual connection to the server from the outside is done securely.
The current bypass is to regex the ShareX return adress to have http://(.*) in the Regex-List and https://$regex:1|1$ in the URL and Thumbnail URL field in your custom uploader settings.

@TannerReynolds
Copy link
Owner

Probably, but you could just leave secure set to true. It will still run and return https without detecting SSL certs

@TannerReynolds TannerReynolds added Invalid Seems like a Non-issue Request New Feature Request labels Aug 17, 2020
@mangosd1337
Copy link
Author

For me it straight up refused to return anything when it wasnt detecting certs. Will try with newest commit.

@AroPix
Copy link

AroPix commented Jun 30, 2021

+1 i have the same problem. It also doesnt work on secure mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid Seems like a Non-issue Request New Feature Request
Projects
None yet
Development

No branches or pull requests

3 participants