Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow reserved characters #3106

Open
stleusc opened this issue Apr 11, 2024 · 2 comments
Open

disallow reserved characters #3106

stleusc opened this issue Apr 11, 2024 · 2 comments

Comments

@stleusc
Copy link

stleusc commented Apr 11, 2024

Tandoor Version

latest

Setup

Docker / Docker-Compose

Reverse Proxy

No reverse proxy

Other

No response

Bug description

Create a recipe with:

  • add ingredient with % as a unit
  • add another ingredient and type % as unit in the search box

Box shows '% create' despite the fact that % as a unit exists already!
Expected: '% select' since % already exists

Relevant logs

No response

@smilerz
Copy link
Collaborator

smilerz commented Apr 11, 2024

% is a reserved character and can't be used in an API (which drives the search).

@vabene1111 - we should probably limit using reserved characters or explicitly encode/decode them.

(for reference: ! * ' ( ) ; : @ & = + $ , / ? % # [ ] are all reserved)

@vabene1111
Copy link
Collaborator

Hmm yea, its all escaped and as you said stripped by the API but the new frontend should probably have some validation to dissallow those characters at least in any name field

@vabene1111 vabene1111 changed the title filter and/or search for % and * disallow reserved characters Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants