Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling up on mobile/trackpad resets position using Dynamic and Vue #622

Open
2 tasks done
JochemvanHout opened this issue Nov 10, 2023 · 3 comments
Open
2 tasks done

Comments

@JochemvanHout
Copy link

JochemvanHout commented Nov 10, 2023

Edit

As described here, this is a working true fix #619 (comment)

Describe the bug

This problem occurs when you use smooth scrolling, i.e. via touch screen or trackpad

Using the 'dynamic' version of the scroller and Vue problems occur when you scroll up. Other versions, such as fixed an variable height work fine.

Scrolling down works fine, however, the second you start scrolling up it causes a jittery movement and the rows don't actually scroll up, instead it resets its position. You can hopefully see it clearly in my provided videos. For example: row 53 stays in view.

The problem is most notable by scrolling slowly. By scrolling really fast you can get over it temporarily, but as soon as the scroll starts slowing down, the problem occurs.

This issue occurs in the offical example!

Your minimal, reproducible example

https://ryhp23-3001.csb.app/

Steps to reproduce

  1. Open on mobile or switch the mobile emulation mode using the devtools
  2. swipe down in the list, this works fine
  3. Swipe up, position keeps resetting

Expected behavior

I expect to be able to smoothly scroll up using the dynamic variant on all platforms.

How often does this bug happen?

Every time

Screenshots or Videos

Screen.Recording.2023-11-10.at.11.16.31.mov
tanstack.scroller.bug.webm

Platform

Problem occurs on:
Chromium on MacOS
Firefox on MacOS
Chrome on Android
Firefox on Android
Firefox on Windows
Edge on Windows

Problem does NOT occur on:
Webkit based browsers basically:
safari on iPhone (emulator)
safari/Chromium/Firefox iPad
Safari on MacOS

tanstack-virtual version

3.0.0-beta.68

TypeScript version

4.8.4

Additional context

The bug does not exist on the React wrapper of virtual.

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@JochemvanHout JochemvanHout changed the title Scrolling up on mobile resets position using Dynamic and Vue Scrolling up on mobile/trackpad resets position using Dynamic and Vue Nov 10, 2023
@JochemvanHout
Copy link
Author

I seem to have found a temporary workaround.

In your useVirtualizer you can set overscan to a relatively high number. This atleasts allows users to scroll that many items before it starts to glitch.

const rowVirtualizer = useVirtualizer({
  count: 1000,
  getScrollElement: () => scrollWrapper.value,
  estimateSize: () => 40,
  overscan: 100,
});

@ghost
Copy link

ghost commented Nov 22, 2023

I seem to have found a temporary workaround.

In your useVirtualizer you can set overscan to a relatively high number. This atleasts allows users to scroll that many items before it starts to glitch.

const rowVirtualizer = useVirtualizer({
  count: 1000,
  getScrollElement: () => scrollWrapper.value,
  estimateSize: () => 40,
  overscan: 100,
});

So sad workaround 😢
tanstack/virtual api looks great, but because of this error, it is impossible to use

@AlejandroAkbal
Copy link

AlejandroAkbal commented Mar 10, 2024

Happening to me too, I've tried to use this library 3 times for the last year and with no luck because of this exact issue

This last try, seems like not setting an overscan works 2/3 of the time

Also, this other workaround seems to work too #659

EDIT: THIS REALLY FIXED IT: #619 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants