Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for fetching Noto Sans font #931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dannysu
Copy link
Contributor

@dannysu dannysu commented Feb 20, 2023

The build instruction for Windows has this manual step. This script automates getting the Noto Sans font from the source.

https://fonts.google.com/noto/specimen/Noto+Sans links to https://github.com/notofonts/noto-source, which then says to go to https://notofonts.github.io/.

@Taiko2k
Copy link
Owner

Taiko2k commented Mar 11, 2023

Fonts are a bit of a messy issue. I haven't documented this anywhere but currently only the fonts I included in the exe bundle are the ones that are used.

Screenshot from 2023-03-11 23-16-29

They are:

  • Noto Sans, (inc Bold, Medium, ExtraCondensed and ExtraCondensedBold)
  • Noto Sans CJK JP versions of the above.

But other language versions won't be used. So importing every Noto font is unnecessary. Also I'm not entirely sure if they can be put in sub folders.

I'm not entirely sure on all this, fontconfig is complicated, and even more complicated on Windows where the behavior is different. But I remember running into performance issues trying to load more fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants