Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients: extend completion request context for intelij idea #2044

Merged
merged 2 commits into from May 17, 2024
Merged

clients: extend completion request context for intelij idea #2044

merged 2 commits into from May 17, 2024

Conversation

vovochka404
Copy link
Contributor

This MR adds some aditional context to completion requests from intelij idea
Fixes #1962

@wsxiaoys wsxiaoys requested a review from icycodes May 4, 2024 02:22
@wsxiaoys
Copy link
Member

wsxiaoys commented May 4, 2024

Thanks for the PR, adding @icycodes

@vovochka404 vovochka404 changed the title Extend completion request context clients: extend completion request context for inteij idea May 4, 2024
@vovochka404 vovochka404 changed the title clients: extend completion request context for inteij idea clients: extend completion request context for intelij idea May 4, 2024
@icycodes
Copy link
Member

Thank you for the PR!
I apologize for the delayed reply. Your contribution to the IntelliJ plugin is very valuable. I will review and merge it soon.
In addition, I am planning to add a system command based git context provider to address scenarios where IDE-provided git APIs are lacking. I will release the new version once these enhancements are completed.

@icycodes icycodes merged commit 42622cb into TabbyML:main May 17, 2024
2 checks passed
@vovochka404
Copy link
Contributor Author

@icycodes thank you :)

As i can see, currently, vscode collects definitions only if enabled in config, but there is no public config for this.
This option currently unavailable in vscode?

Do you have any idea how to implement this in intelij idea plugin? I see it only through separate definition providers for each supported language.

Or there is no plans to evolve this functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icycodes icycodes icycodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add git/workspace support to intelij plugin
3 participants
@vovochka404 @wsxiaoys @icycodes