Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much subset routine's base code is within the subset fuction #16

Open
rogerkuou opened this issue Feb 28, 2023 · 0 comments
Open

Too much subset routine's base code is within the subset fuction #16

rogerkuou opened this issue Feb 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@rogerkuou
Copy link
Member

rogerkuou commented Feb 28, 2023

I still think too much of each subset routine's base code is within the routine. I would suggest trying to move that out, only making a call from the subset function. This would also help with future additions of subset methods

Originally posted by @meiertgrootes in #10 (comment)

@rogerkuou rogerkuou added the enhancement New feature or request label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant