Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Georgia-ReBORN Wine Bugs on Linux #2

Open
TT-ReBORN opened this issue May 16, 2021 · 11 comments
Open

Georgia-ReBORN Wine Bugs on Linux #2

TT-ReBORN opened this issue May 16, 2021 · 11 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@TT-ReBORN
Copy link
Owner

TT-ReBORN commented May 16, 2021

Works on Windows but with Wine there are following bugs:

- Drag and drop music files to Playlist is not working. See reported Wine bug here.
Wait until @TheQwertiest does fix dnd bug since SMP 1.6.0 to apply Wine workaround, see here.
( Drag and drop works in the window if you use Files -> Add files/folder ).
NEW: since Beta 11, drag n drop is fully operational, you need to downgrade and use Spider Monkey Panel v1.5.2:
https://github.com/TheQwertiest/foo_spider_monkey_panel/releases/tag/v1.5.2

The playlist drag and drop issue has been fixed by Wine devs since Wine 8.
There is no more need to downgrade to Spider Monkey Panel v1.5.2, just use the existing SMP in the theme.

  • If you use display auto-detect or going in and out of fullscreen and then drag and drop the player around,
    it will freeze foobar. You can CTRL + ALT + DEL and hit ESC and then restart foobar.
    ( This is due to the active default option "Allow the window manager to control the windows" in the Graphics tab
    in the Wine config. This option can be disabled, but foobar will be always on top of everything even if it's not active ).

  • Native Library/Biography options menu and Library/Biography right click search context menu is disabled
    due to incompatibility. Please use top menu Options > Library/Biography menu instead.

If you encounter any other bugs please post them here, thank you.

@TT-ReBORN TT-ReBORN added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels May 16, 2021
@TT-ReBORN TT-ReBORN changed the title Georgia ReBORN Wine Bugs under Linux Georgia-ReBORN Wine Bugs under Linux May 22, 2021
@TheQwertiest
Copy link

drag n drop big might be related to TheQwertiest/foo_spider_monkey_panel#60

@TT-ReBORN
Copy link
Owner Author

TT-ReBORN commented Jun 23, 2021

@TheQwertiest Native drag n drop in original foobar works.

In my case and Mordred's you can drag ( selection is displayed ) the music folder onto the playlist, a plus icon will be also displayed but if you drop nothing happens. No music files are added, the command/execution will be ignored...

00f4:fixme:clipboard:import_text unsupported TEXT type "TEXT" 00f4:fixme:shell:IDropTargetHelper_fnDragEnter (0x205998)->(0x10078 0x7db4b3b8 0x31f9a0 0x00000001) 00f4:fixme:xdnd:XDNDDATAOBJECT_SetData (0x7db4b3b8, 0x31f4a8, 0x31f4bc, TRUE): stub 00f4:fixme:shell:IDropTargetHelper_fnDragOver (0x205998)->(0x31f9a0 0x00000001) 00f4:fixme:xdnd:XDNDDATAOBJECT_SetData (0x7db4b3b8, 0x31f4c8, 0x31f4dc, TRUE): stub 00f4:fixme:xdnd:X11DRV_XDND_DROPEFFECTToXdndAction unknown drop effect 0, assuming XdndActionCopy 00f4:fixme:shell:IDropTargetHelper_fnDragOver (0x205998)->(0x31f9a0 0x00000001) 00f4:fixme:xdnd:XDNDDATAOBJECT_SetData (0x7db4b3b8, 0x31f4c8, 0x31f4dc, TRUE): stub 00f4:fixme:xdnd:X11DRV_XDND_DROPEFFECTToXdndAction unknown drop effect 0, assuming XdndActionCopy 00f4:fixme:shell:IDropTargetHelper_fnDragOver (0x205998)->(0x31fa60 0x00000001) 00f4:fixme:xdnd:XDNDDATAOBJECT_SetData (0x7db4b3b8, 0x31f588, 0x31f59c, TRUE): stub 00f4:fixme:xdnd:X11DRV_XDND_DROPEFFECTToXdndAction unknown drop effect 0, assuming XdndActionCopy 00f4:fixme:shell:IDropTargetHelper_fnDragOver (0x205998)->(0x31f9a0 0x00000001) 00f4:fixme:xdnd:XDNDDATAOBJECT_SetData (0x7db4b3b8, 0x31f4c8, 0x31f4dc, TRUE): stub 00f4:fixme:xdnd:X11DRV_XDND_DROPEFFECTToXdndAction unknown drop effect 0, assuming XdndActionCopy 00f4:fixme:shell:IDropTargetHelper_fnDragLeave (0x205998)->() 00f4:fixme:xdnd:XDNDDATAOBJECT_SetData (0x7db4b3b8, 0x31f430, 0x31f444, TRUE): stub

I don't know if it's a problem with SMP or if it's the drag n drop code in the playlist you've ( or Mordred? ) written.
I also tried with all user-components removed using SMP with DUI only without any luck...

@TT-ReBORN
Copy link
Owner Author

Note for myself: Always if possible use TrueType fonts when using Wine.
The only downloadable form of GDI+ is for Windows XP, and Windows XP never supported OTF.

@TheQwertiest
Copy link

Drag-n-drop bug might be fixed on the latest dev build

@TT-ReBORN
Copy link
Owner Author

Updated bugs, see first post.

TT-ReBORN added a commit that referenced this issue Nov 23, 2021
… menu in Wine/Linux by disabling clipboard paste func #2 - Can be reverted once there is a SMP fix...
@TT-ReBORN
Copy link
Owner Author

New thread started here:
https://hydrogenaud.io/index.php?topic=121786.0

@TT-ReBORN
Copy link
Owner Author

Biography image fetching works, this is needed:

See this Winecfg

@TT-ReBORN
Copy link
Owner Author

TT-ReBORN commented Feb 24, 2022

Note: Update library and biography clipboard funcs with @marc2k3's implementation of
utils.GetClipboardText / utils.SetClipboardText see here: TheQwertiest/foo_spider_monkey_panel#158

TT-ReBORN added a commit that referenced this issue Apr 17, 2022
# Theme:
- Added new theme "Random" -> Options > Theme > Random
- Random theme will generate random colors that are NOT based on album art
- Random theme has an auto color timer feature that can be set in Options > Style > Auto color
- Double clicking on lower bar in Random theme will generate a new color
- Reborn theme ( also Random theme ) has now dynamically adjusted shadow opacity ( previously panel shadows were nearly invisible on darker colors )
- Reborn theme will adjust colors when cycling through images

# Styles:
- Added various theme styles -> Options > Style ( different styles for each individual theme ):
- Bevel
- Blend, Blend 2
- Gradient, Gradient 2
- Alternative, Alternative 2
- Black and white, Black and white 2, Black and white reborn
- Black reborn
- Reborn white, Reborn black
- Random pastel, Random dark, Auto color
- Theme styles also available for top menu buttons, transport buttons, progress and volume bar:
- Filled, Bevel, Emboss, Inner, Minimal
- Progress bar and volume bar have an additional Rounded style

# QHD:
- Added QHD mode -> Options > Display
- Added 9 predefined player sizes for QHD
- Added automatic QHD detection
- Added pre-optimized/adjusted font sizes for QHD

# Various:
- Added adjustable brightness -> Options > Brightness
- Added Create/Restore backup and theme reset -> Options > Settings > Theme settings
- Added more font sizes for scaling
- Added missing mouse hover animation for library and biography scrollbar thumb
- Added new Playlist tools menu
- Added shortcut Alt + Left click automatically adds tracks from Library to Playlist
- Added option to show artist name in playlist if it's not the same as album artist -> Options > Playlist > Show artist name on difference
- Added option to fallback to last.fm scrobbles if no local play count exist -> Options > Playlist > Show last.fm scrobbles on no local plays
- Added option to disable album art when displaying lyrics -> Options > Lyrics > Show album art when displaying lyrics
- Added jump search also for Playlist. Jump search can be activated in all panels and if not first activated in the Library, it will show results first in the Playlist and if no results were found then it will try in the Library.
- Increased up to 6 country flags
- Optimized and reordered some top menu options items
- Top menu minimize, fullscreen, close button scaling
- Corrected overlapping of artist & album title in playlist
- Fixed library nowPlaying when using option "Always scroll to current playing song" and synced with Playlist
- Fixed library arrow keys navigation
- Fixed progress bar fill color when playing from a CD
- Fixed cosmetic font bump when changing other layout transport button sizes while current active layout is different
- Removed Deezer source from lyric search ( caused instability )
- Reactivated clipboard funcs in library and biography for Wine/Linux users #2 ( no more right click crashes ) thx @marc2k3 =)
- Various bug fixes and fine tuning

# Performance:
- Huge code rewrites/refactoring and cleanup -> it's basically a new theme =)
- Much faster overall performance
- Faster loading times
- Active playlist with a ridiculously huge amount of tracks no longer a performance killer when resizing the player
  ( Only on foobar startup/theme reload and when you add to playlist, obviously you need to fully init the playlist content )
- Updated to @marc2k3's modified Spider Monkey Panel v1.6.2-dev+7c0928bf
  ( Included marc2k3's utils.GetClipboardText/utils.SetClipboardText )

# Components:
- Updated foo_multisource to v0.56
- Included Mordred's foo_musicbrainz user-component ( is now the standard tagging tool )

Note: Theme style Blend will take a performance hit, this also varies on player size ( Small -> Large, HD -> 4K ).
Theme styles are still beta, additional fine tuning needs to be done. This update can be seen as the first public release but still in beta phase,
next update will be the first public release with all stuff fixed from this update.
@TT-ReBORN TT-ReBORN removed help wanted Extra attention is needed good first issue Good for newcomers labels Jul 31, 2022
@TT-ReBORN TT-ReBORN pinned this issue Jul 31, 2022
@TT-ReBORN TT-ReBORN unpinned this issue Jul 31, 2022
@TT-ReBORN TT-ReBORN reopened this Jul 31, 2022
@TT-ReBORN TT-ReBORN added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 31, 2022
@TT-ReBORN TT-ReBORN self-assigned this Jul 31, 2022
@TT-ReBORN TT-ReBORN changed the title Georgia-ReBORN Wine Bugs under Linux Georgia-ReBORN Wine Bugs on Linux Aug 1, 2022
@TT-ReBORN
Copy link
Owner Author

TT-ReBORN commented Sep 15, 2022

Note for myself and @TheQwertiest: Workaround fix for Wine drag and drop bug does not work since SMP 1.6.0, i.e change
action.Effect = this.filter_effect_by_modifiers(action.Effect); to action.Effect = g_drop_effect.copy; in on_drag_over(action, x, y, mask) and on_drag_drop(action, x, y, m) in the Playlist. More information here.

@TT-ReBORN
Copy link
Owner Author

NEW: since Beta 11, drag n drop is fully operational, you need to downgrade and use Spider Monkey Panel v1.5.2:
https://github.com/TheQwertiest/foo_spider_monkey_panel/releases/tag/v1.5.2

@TT-ReBORN
Copy link
Owner Author

The playlist drag and drop issue has been fixed by Wine devs since Wine 8.
There is no more need to downgrade to Spider Monkey Panel v1.5.2, just use the existing SMP in the theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants