Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist text sometimes kerned, sometimes not #107

Open
suedunham opened this issue Mar 27, 2023 · 1 comment
Open

Playlist text sometimes kerned, sometimes not #107

suedunham opened this issue Mar 27, 2023 · 1 comment

Comments

@suedunham
Copy link

suedunham commented Mar 27, 2023

I don't know if I should bring this up with you, The Qwertiest, or elsewhere, but the image I have is from your theme. I've noticed it too in my own theme where I'm trying to use the CaTRoX playlist viewer. Both of those are in the current beta of foobar2000 v2 with Windows 10.

I've noticed that the text of my track titles doesn't always line up as I expect it to. This is apparent in Classical albums where a sequence of many tracks all start with the same text. For instance, tracks 30–6 in the image below all belong to the same piece, but numbers 34 and 35 look slightly out of alignment when seeing how the text lines up with the rest. The "D Major" looks a bit outdented.

variations

Looking more closely, the variation seems to be in, well, the word "Variation". In most of the tracks, the "V" and "a" don't appear to be kerned, but in #34–5, they are.

I've looked at this album in a different foobar2000 installation that uses the default CUI playlist viewer, and they all line up there. So this doesn't seem to be an issue with the tracks themselves.

@TT-ReBORN
Copy link
Owner

Hi @suedunham,

this is a SMP GDI issue and problem is the rendering of the roman numerals in the track titles using the DrawString method.
If using the GdiDrawText method, the rendering is OK but vertical alignment not...
It is stated in the SMP docs, that DrawString should be used when using transparent backgrounds and/or ClearType rendering. That is the case on some styles the theme is using when activated, so I don't think I will change it...
TheQwertiest wants to implement Direct2D and put the old, buggy and slow GDI+ into the trash bin where it belongs.

Maybe @TheQwertiest could comment on this.

-TT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants