DEV TESTING

[TT-ReBORN]

CURRENT VERSION: Second Release Candidate - Georgia-ReBORN v3.0-RC2: DOWNLOAD FROM HERE.

P.S Just a reminder for anyone who did not know, you can always download the master as you like.
If you go to the main page here and at the top click on the green <> Code button > Download ZIP.

---

Note for Wine/Linux users:
There is a Wine/Linux bug in the playlist drag and drop, a workaround fix was applied in the playlist.
To be able to use playlist drag and drop on Wine/Linux, you need to downgrade and use Spider Monkey Panel v1.5.2:
https://github.com/TheQwertiest/foo_spider_monkey_panel/releases/tag/v1.5.2

The playlist drag and drop issue has been fixed by Wine devs since Wine 8.

---

Developers might be interested to take a look at the DEV CORNER thread here: #171

---

Posted issues that have been fixed, will be deleted to have a better overview of messages, thank you for the bug report!

Cheers

-TT

[Meisfuture]

Hi Tom, 风里尘 has filed a bug with you where the search results are not playing correctly when the source is the active list.

Bug.mp4

[TT-ReBORN]

Thanks for reporting @Meisfuture, I can confirm this behavior is also present in the original Library script.

---

@Wil-B,
when typing only one letter in the Library search, we should show all artists only for that letter.
So I assume it is not working properly, will take a look once I have updated to your latest Biography version...

-TT

[TT-ReBORN]

@Wil-B,

just realized ( a little bit too late 😅 ) that in Biography, the item properties view and nowplaying view is not available when lyrics are found and displayed. Shouldn't we make this also possible to have item properties and nowplaying accessible regardless when lyrics are found? Did I miss something? Just checked and it is the same behavior in your original Biography.

Because of the new lyrics sources I have written for ESLyric, Georgia-ReBORN automatically saves and displays lyrics when found and that is almost for every song now, that means I didn't even realize the missing item properties and nowplaying views. I have forgot about those but I knew in the past they existed but couldn't figure out why they were not being displayed, I mean the behavior when
lyrics were loaded... took me an hour to figure this out 😅

What's your opinion about that?

-Tom

[regorxxx]

Well looking at bio code, there are also a few request being made without returning a promise, so there are a few places which should be rewritten

https://github.com/Wil-B/Biography/blob/4ca106bfe48727420f0d9ffc3645b75533c6ed69/scripts/lastfm.js#L307

[TT-ReBORN]

Yes, its these:

Georgia-ReBORN/profile/georgia-reborn/scripts/Biography/scripts/bio-lastfm.js

Line 60 in 7604c1f

try { this.xmlhttp.send(); } catch (e) {}

Georgia-ReBORN/profile/georgia-reborn/scripts/Biography/scripts/bio-lastfm.js

Line 309 in 7604c1f

try { this.xmlhttp.send(); } catch (e) {}

Georgia-ReBORN/profile/georgia-reborn/scripts/Biography/scripts/bio-lastfm.js

Line 441 in 7604c1f

try { this.xmlhttp.send(); } catch (e) {}

Georgia-ReBORN/profile/georgia-reborn/scripts/Biography/scripts/bio-lastfm.js

Line 841 in 7604c1f

try { this.xmlhttp.send(); } catch (e) {}

Georgia-ReBORN/profile/georgia-reborn/scripts/Biography/scripts/bio-lastfm.js

Line 903 in 7604c1f

try { this.xmlhttp.send(); } catch (e) {}

Georgia-ReBORN/profile/georgia-reborn/scripts/Biography/scripts/bio-wikipedia.js

Line 603 in 7604c1f

try { this.xmlhttp.send(); } catch (e) {}

I have done tests and its working good... I took the easy way :p

[regorxxx]

Personally I would reuse the same method everywhere and catch the promise, which is easier to maintain (on future bio versions), but that will do too.

[regorxxx]

Also don't forget to apply my pull request, otherwise you will get infinite loops on bio request when network is not working, using 100% of the processor at some point xd

[TT-ReBORN]

Yes you are right, the reason I took the easy way is that I do not want too much differ from the original bio code, because I already done much changes and it sucks when updating the bio code from the original code when WilB is doing new updates. If you know what I mean...

P.S Thanks, I already have added your fix some time ago. I have also notifications on WilB's library and bio repos, that is why I saw it ;-)

[TT-ReBORN]

Hey guys, it is showtime!

This was once in a life time operation and I have rewritten the whole Georgia-ReBORN!
It took me more than a month, with 74 backups and lot of stress and work... BUT it was definitely worth it!
Now the whole code base has full OOP architecture, very nicely structured and absolutely clean, it became a great framework.
This means, Georgia-ReBORN has a new clean, structured home with an improved motor ( improved general performance by ~30-40% )
I am very happy with the end result and it is a joy to work with.

BEFORE YOU DO ANYTHING, FIRST MAKE A THEME BACKUP NOW.
I ALSO RECOMMEND TO MAKE A NEW FOOBAR INSTALL BECAUSE IT IS A BIG UPDATE.
You can download the DEV version as usual from here:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

---

1. Please make a theme backup via Options > Settings > Theme backup > Make backup.
2. Now make a new portable foobar install and install the latest DEV master version from here:
   https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip
3. After you have downloaded and installed the theme, copy from your old foobar your theme backup folder:
   foobar2000_old\profile\backup
   to your new:
   foobar2000\profile\backup
4. Then copy the new custom config from:
   foobar2000\profile\georgia-reborn\configs\georgia-reborn-custom.jsonc
   to your backup directory:
   foobar2000\profile\backup\profile\georgia-reborn\configs\
5. Now restore your theme backup via Options > Settings > Theme backup > Restore backup

---

New update changelog:

• Rewrote Georgia-ReBORN into a full-fledged OOP framework:

  • Introduced a clean, new class architecture with improved encapsulation and initialization.
  • Enhanced code organization with collapsible sections in IDE for better navigation.
  • Reorganized script files for clearer structure.
  • Eliminated almost all global variables, retaining only common enums.
  • Refactored numerous functions for efficiency and readability.
  • Optimized overall theme performance, resulting in ~30-40% improvement.
  • Overhauled the playlist script for better modularity.
  • Significantly boosted playlist performance with faster thumbnail fetching and smoother scrolling.
  • Expanded and improved JSDocs for better developer guidance.

• Added a new "Add tracks" button (+) that adds selected albums/tracks from Library or Playlist to user defined playlist.

  • Can be displayed via top menu Options > Player controls > Lower bar > Show add tracks button
    or right click on lower bar for context menu > Display > Show add tracks button.
  • The default playlist for using the add tracks button is "Favorites", the add tracks button playlist can
    be changed via top menu Options > Player controls > Lower bar > Add tracks button > Add tracks playlist
    or right click on lower bar for context menu > Controls > Add tracks playlist.
  • When adding albums/tracks from the Library or Playlist (to another playlist), you can activate additionally
    top menu Options > Player controls > Panel > Switch to playlist when adding songs
    or right click on lower bar for context menu > Controls > Switch to playlist when adding songs.

• Added auto-download biography and auto-download lyrics modes.

  • Developer tools need to be enabled first via top menu Options > Settings > Developer tools.
  • Both modes can be activated via top menu Options > Developer tools > Enable auto-download biography/lyrics.
  • The auto-download biography mode has a 5 sec timer interval to play a new track for an artist
    and then shuffles to another artist.
  • The auto-download lyrics mode has a 15 sec timer interval that does the same to fetch the lyrics for the tracks.
  • It works the best if you leave your PC unattended for a longer period of time and when you come back,
    all the stuff has been downloaded.

• Added new codec logos, thx @ZavierQuixote =)

• Removed and merged Options > Lyrics > Controls > Remember active lyrics state into Remember lyrics panel state

  • This was confusing and unneeded, functionality remains the same as both features are merged into one now.

• Removed Options > Library > Controls > Switch to playlist when adding songs.

  • The new feature can be now found in top menu Options > Player controls > Panel > Switch to playlist when adding songs.
  • Due to the new "Add tracks" button, this Library only feature has been enhanced for additional Playlist usage.

• Fixed a rare disc art rotation crash.

• Fixed a playlist custom track pattern issue that displayed duplicated track number indexes.

• Fixed very old sticky scrollbars, when scrollbars are being dragged and mouse button was clicked outside the window.

• Fixed some cosmetic bugs.

---

Because of these huge changes, there may be new introduced bugs, but it looks good.
If you find anything please keep on reporting bugs as usual.
Let's make v3.0 final a good stable version!

Thanks guys!

-Tom

[Zephyr0ck]

I've added my custom vinyl placeholder, but in context menu I'm getting an error:

Video_2024-02-22_093126.mp4

I've edited too gr-menu-context.js but can't find any solution.

Regards, Tom! 👍

[TT-ReBORN]

Hi José,
how are you doing, you were quiet for some time :-)

Actually I found out that the title formatting in the config file never worked...
I have never changed it in the config file and no one ever reported this, so it hasn't worked since the beginning of Georgia-ReBORN!
It's good you find out, would be bad if it didn't work in v3.0 final... 😅
I have fixed it in the latest commit.

About the custom disc art. I have improved it and made it much more easier for the users, no more fiddling in the JavaScript files!
The user can just add the name for the cd or vinyl stub directly in the:
foobar2000\profile\georgia-reborn\configs\georgia-reborn-custom.jsonc file in the section "customDiscArtStub"
Take a look @d3rb, he added all his custom disc art placeholder in his georgia-reborn-custom.jsonc. https://github.com/d3rb/Placeholder-for-Georgia-ReBORN , just download his repo and you will see.

This is a much better solution, add your custom disc art placeholders only once and use your custom config every time a new update
will be released. So no more tedious crap in adding those in the JavaScript files. You can add as many custom disc art placeholders
as you want in your custom config and they will be automatically added to the menu and context menu. You can then also share it with other users, like @d3rb did.

I will take a look about the lower bar time.

Thanks for all the reports!

-Tom

[TT-ReBORN]

@Zephyr0ck, also fixed the repaint left overs on lower bar time when using custom theme fonts with large letter space.
All reported bugs should be fixed in the master version.

[TT-ReBORN]

Btw, I really like your Red smoke Vinyl, Purple Vinyl, Goldess Vinyl, they look great!
I'm sure others look also great when you have the right background color!

When I have more time, I will also do some placeholders ( x10 ) for each official custom theme.
And also new general ones with cool effects, I have some nice ideas!

[TT-ReBORN]

@Zephyr0ck,

I forgot to tell you, you need to put your custom placeholders into your:
foobar2000\profile\georgia-reborn\images\custom\discart
Your custom placeholders filenames need to be the same as in your "customDiscArtStub":
foobar2000\profile\georgia-reborn\configs\georgia-reborn-custom.jsonc file.

-Tom

[TT-ReBORN]

Message to all Beta testers who are testing the new Georgia-ReBORN DEV version:

I won't be implementing any new big features ( maybe some small ones, dunno ) until v3.0 final has been released
and I won't be making any big code changes anymore.
That means, I will implement only when WilB has released the new Library with itunes layout design.

So guys, the highest priority is to find all bugs and report them to me. Let's make v3.0 final a great release!
This will be the last big beta testing! Thanks to all beta testers!

---

Georgia-ReBORN statistics from SonarCloud:
Lines: 92,201
Lines of Code: 70,803
Comment Lines: 14,506
Statements: 45,535
Functions: 4,928
Classes: 156
Files: 94

Yes, Georgia-ReBORN has lot features 😏
Another high priority will be to also finish the Georgia-ReBORN website with its documentation, so other users
can fully grasp its potential. But there is also a lot of work to be done...

-Tom

[TT-ReBORN]

For those who are interested in disc art placeholders:
I have spent a week to design new disc art placeholders because the themes
Blue, Dark blue, Red, Cream, Neon blue, Neon green, Neon red, Neon gold and all Custom themes did not have
specifically designed disc art placeholders for those themes. I designed and added them in the latest commit:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

If you are using the latest DEV version and do not want to reinstall, you can download the master version
and then delete those existing dirs in your profile and add those from the zip:
foobar2000\profile\georgia-reborn\images\custom
foobar2000\profile\georgia-reborn\images\discart

For those who have edited their custom config, otherwise ignore and replace it:
foobar2000\profile\georgia-reborn\configs\georgia-reborn-custom.jsonc
make a backup and use the config from the master zip because I have added the custom disc art placeholders for the custom themes
in "customDiscArtStub" section.

Now the new disc art placeholders are available top menu Options > Details > Disc art > Disc art placeholder.
Of course a better accessibility would be to go to Details panel > right click on album art > Details options menu > Disc art > Disc art placeholder. This is a good approach if you need to configure additional Details options but the fastest way is just:
Details panel, right click on album art > Disc art placeholder.

I think the Neon blue, Neon green, Neon red, Neon gold and all Custom themes disc art placeholders look pretty cool
when using them with its themes.

P.S For those who use my Georgia-ReBORN resources, I have updated all PSD files with all new disc art placeholders here:
https://github.com/TT-ReBORN/Georgia-ReBORN-resources

-Tom

[d3rb]

Hello Tom, nice update an nice work, I like the new neon placeholders, the neons look very good and the glow lighting effect is really cool.
And thanks for adding “Custom” in the placeholder menu. This is nice and clear and makes it easier to navigate to the custom placeholder.

good job Men :)

greetings

[TT-ReBORN]

I realized that we did not have any theme specific theme placeholders that is why I made them,
because the common placeholders are not optimal for all use cases ( background theme colors ).
I guess the common disc art placeholders were only good for theme White, Black, Reborn, Random.

As mentioned in previous posts, I do have lots of nice ideas for common disc art placeholders but I do not have enough time for
this and have higher priorities. Maybe in the future I will make some more...

Anyways glad you like it =)

-Tom

[acstrp]

In split mode, if you right click in playlist then select:

collapse/expand > auto

and uncheck it, it always resets to checked (either switch to full or normal layout then back to split, or simply hit the library button in the menu bar twice).

Is this intentional? I always deselect it and it always comes back. Auto is the only thing checked in that menu.

[TT-ReBORN]

Yes, that is indeed intentional. It is the activated Library split layout presets by default.
My reasoning for using the playlist header auto-collapse in Library split layout is to have better drag and drop
albums/tracks from Library to the Playlist and also the playlist scrolling is much shorter.

So if you want to change the behavior, you should deactivate the Library split layout presets in
top menu Options > Library > Layout > Use split preset ( all should be deactivated ).
Or just right click for context menu in the Library > Library options menu > Layout > Use split preset ( all should be deactivated ).

Just checked and saw that when you disable the Library split presets, you also need to expand all collapsed playlist headers
while Library split mode is being displayed. I will add that automatically so users do not need to be bothered...
Edit: Just made a commit for this...

I think the "default" behavior when using the presets, ( Library split/full width presets, Biography full width preset )
confused some users in the past, I will mention and write it clearly in the documentation.

-Tom

[acstrp]

Awesome, thank you! Figured it was likely intentional but if it leads to some expanded documentation, glad I asked.

I like pretty much all the default preset behaviors for the most part though. I'll give the default split options another try, you might be right.

[acstrp]

A couple times recently have received a popup box with the message:

Album art could not be properly parsed!

Maybe it is corrupt, file format is not supported
or has an unusual ICC profile embedded.

Restarting foobar resolves the issue.

Once it happens the first time, it happens on any album that has larger png art (haven't narrowed down the size, 5MB is ok, 12MB causes the error) then if I keep going to different albums I get a crash:

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-DEV by TT)
Resize failed:
Failed to create GdiPlus object (0x2): InvalidParameter

File: gr-main.js
Line: 3980, Column: 22
Stack trace:
  createDiscArtCoverMask@gr-main.js:3980:22
  createDiscArtRotation@gr-main.js:3995:10
  loadImageFromAlbumArtList/<@gr-main.js:3779:28

I usually just leave foobar open and it seems to happen after some number of days, never after a fresh launch, it was using over 3GB of ram when it just happened. After a fresh launch foobar is back to under 200MB ram usage

Edit: guess foobar is getting to the 32bit memory usage limit, but this never happened before I updated to the March 23rd master - I had the same version of foobar open for a month before that update with no issue, now I am hitting a memory limit after about 5 days.

Double edit: all of my artwork is external files / most artwork is 5MB+ / I have increased the max external artwork size to 16MB. Also I have been pretty bad at updating to the latest DEV version so not sure how recent a version I was running before I updated on March 23rd.

[acstrp]

Nice, thanks, I'll keep my eye on it over the next few days to make sure.

The initial 'out of memory' errors sure were misleading, coupled with the fact it was taking multiple days to occur during regular use.

Now I feel bad that I found a bug and it wasn't even really a ReBORN bug... I'll try to do better next time!

[TT-ReBORN]

No, it is quite the opposite, I'm grateful that you have reported it.

Memory leaks are always bad and should be fixed asap, I have never encountered it because I already had
lyrics in cache downloaded or it never reached to the LyricsOnDemand source because other higher prioritized sources
already found it.

I am quite happy with the rewrite and its state now, it seems quite stable and much better than the previous versions ( RC2, RC1, older ).
There may be some small remaining reference errors or typos but most have been fixed you guys have reported to me.

I will release the DEV version as v3.0 final for the public soon, but I need to finish the website with its documentation first
and in the meantime wait if you guys find some other bugs.

-Tom

[acstrp]

True, memory leaks are the opposite of failing gracefully, definitely glad that was caught.

Forgot to say, I have definitely been enjoying the rewrite -- it's not a night and day difference but having used the prior version so much, now I notice that certain things are just a touch more responsive and snappier. So it's basically the same... just better!

[acstrp]

Quick update: no issues.

foobar has been opened for a little over 6 days and no memory leaks or cpu usage issues. RAM usage is hovering around 300MB.

Random unrelated comment - I am firmly in the "great job removing the foobar icon from the system tray" camp.

[TT-ReBORN]

Thanks for the report and confirmation, I have reported it to ttsping here:
ESLyric/feedback#149

I'll remove it from the Georgia-ReBORN repo too.

[Meisfuture]

Hi Tom, is it possible to use jscript panel 3 instead of spider monkey panel to convert Georgia-ReBORN to 64 Bit? I'm currently stacking a 64 interface with jscript panel 3.

[TT-ReBORN]

Hi @Meisfuture =)

unfortunately it is not possible. Porting Georgia-ReBORN to Jscript Panel 3 would be a downgrade.
Jscript Panel 3 uses very old JavaScript syntax and features, you would need to rewrite the whole theme and Jscript Panel
has no future. Spider Monkey Panel is the successor of Jscript Panel, the dev, @TheQwertiest only needs to be more active and complete Spider Monkey Panel v2 =). There will be SMP x64 as it is planned here: TheQwertiest/foo_spider_monkey_panel#213

Also here: #102

-Tom

[silverwings15]

caught these two bugs when i select multiple tracks in Explorer and press Enter

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-DEV by TT)
pptBio is not defined

File: advanced_radio_stream_parser.js
Line: 20, Column: 37
Stack trace:
  getStreamInfo@advanced_radio_stream_parser.js:20:37
  artist@bio-names.js:52:106
  getBio@bio-server.js:229:41
  download@bio-server.js:202:8
  bio.timer.zSearch.id<@bio-initialise.js:69:14

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-DEV by TT)
pptBio is not defined

File: advanced_radio_stream_parser.js
Line: 20, Column: 37
Stack trace:
  getStreamInfo@advanced_radio_stream_parser.js:20:37
  artist@bio-names.js:52:106
  getText@bio-text.js:1688:32
  on_size@bio-text.js:2246:8
  on_size@bio-callbacks.js:586:11
  setBiographySize@gr-main.js:5021:12
  refreshProp@bio-interface.js:596:10
  updateProp@bio-interface.js:762:8
  setNoAlbumArtColors@gr-theme-colors.js:6035:11
  initTheme@gr-main.js:2010:14
  fetchAlbumArt@gr-main.js:3676:10
  fetchNewArtwork@gr-main.js:3697:8
  on_playback_new_track@gr-callbacks.js:212:10

also, can you make it so the whole list of tracks selected in Explorer would be added to the playlist when I press Enter? right now only the bottom track is added.

[TT-ReBORN]

Thanks for reporting, this is was older issue that was fixed a week ago or so.

Just download the latest DEV version:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip
and replace your files.

And remove this file from your cache:
foobar2000\profile\cache\biography\advanced_radio_stream_parser.js

After that start foobar as usual, this will create the new fixed advanced_radio_stream_parser.js in your cache and all should be good.

-TT

[TT-ReBORN]

also, can you make it so the whole list of tracks selected in Explorer would be added to the playlist when I press Enter? right now only the bottom track is added.

Not sure what you mean by that, I just tested the standard foobar installation with the DEV version and there are no issue at all.
I select all tracks via mouse and hit Enter and alll will be added to the Playlist, or select only a few with SHIFT + click or odd selections with CTRL + click and it works as expected.

[silverwings15]

oh sorry about that, i found out it's because i'm using a different file manager. it works fine on File Explorer like you say

[mauriva]

A small observation.
It may be intentional (so not a bug), but with Georgia-Reborn the icon in the systray is never visible
What are in "Preferences - Display - Default User Interface - Background and Notifications." are definitely ignored, but it would be useful to be able to display the icon in the systray, perhaps with the ability to access a mini-menu with some control over the player...

[TT-ReBORN]

Yes, I never liked the foobar icon to be visible in the system tray.
My reasoning is simple, I prefer to have system programs only in the right systray and not general programs.

Georgia-ReBORN uses the Columns UI ( CUI ) user-component and not foobar's Default User Interface ( DUI ).
You can enable it via foobar's Preferences > Display > Columns UI. At the top right, select Notification area tab > Always show icon.

Actually there is a mini-menu if you mouse hover the foobar icon in your task bar.

-Tom

[silverwings15]

i'm using the latest Xyplorer (https://www.xyplorer.com/download/xyplorer_full.zip) as the default file manager (Config -> Other -> Shell integration). when i use right click a track in foobar and open its containing folder, foobar UI freezes up for about 10-15 seconds, though the file is still instantly shown in Xyplorer interface. does not happen with FIle Explorer or with my previous default file manager Directory Opus. can you please investigate?

[TT-ReBORN]

I have tried this shareware Xyplorer program and it has performance issues, there is nothing wrong with Georgia-ReBORN.

Tried the very first Georgia-ReBORN version, and opened containing folder which starts this Xyplorer program and it freezes/lags the player for 10 seconds like you are experiencing. I thought that maybe UIHacks could be the issue but I tried original vanilla foobar without any components and it is the same. When opened containing folder showing the Xyplorer program, it also freezes foobar because I can not close foobar for 5-8 seconds.

So the issue is the Xyplorer program that eats your CPU and degrades performance ( i.e that why the freeze/lag happens ) for a short period of time when opening files through this explorer. Just uninstall and delete this crap and be sure to avoid shareware programs in the future ;-)

-Tom

[silverwings15]

thank you for the investigation! that's very weird because Xyplorer is actually one of the older and best known 3rd party file managers for windows. will have to report this to the devs..

[silverwings15]

another issue: when you hover the cursor over a non-playing track and its name glows up to indicate that, the glow disappears within .5-1s, which i don't think is intended. happens on all themes i tried. i can record a video if you cannot reproduce. my settings is basically just the default settings from the files you provide on github, as i'm still waiting for 3.0 final to start tweaking

[TT-ReBORN]

Thanks for reporting this issue.

Actually this was a very very old cosmetic issue I was aware but I didn't fix this because it rarely happened for me and I forgot it. It was a pain in the ass to implement the playlist row hover effect when I started with Georgia-ReBORN and the code was
sub-optimal. I have now rewritten it and it is much better now, the cosmetic issue should be fixed. This was one of the
last old code that still remained.

You can download the master: https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip
and just replace your scripts folder as usual foobar2000\profile\georgia-reborn\scripts

---

i'm still waiting for 3.0 final to start tweaking

You do not need to wait, everyone can already tweak their foobar and Georgia-ReBORN since RC-2 because the theme backup works fine since RC-2. Once v3.0 is released, everyone can just copy their backup folder into a new foobar install ( portable or standard ) and restore their theme backup. All your settings will be restored since your last theme backup creation.

-Tom

[silverwings15]

awesome, tyvm

[TT-ReBORN]

Ok guys, you all need to remove the Lyrics on Demand source, I have already removed it from the master version but
you need to manually remove it from your foobar:

The Lyrics on Demand search script that is not working anymore causing a buffer overflow.
I guess the website devs implemented some anti-scraping measures to prevent lyric scrappers to fetch the lyrics from their
website. Not a tragic loss because their lyrics sources were the same as musixmatch.

Go to foobar's Preferences ( CTRL + P ) > Tools > ESLyric > Lyric Option > Lyric Sources
and find the LyricsOnDemand (Unsynced) lyrics source, right click on it and select Delete.
Restart foobar and all should be good.

---

Btw I have implemented interface mouse wheel scrolling in the latest commit, imo this feature was missing.
It was a bit tedious to always go to top menu Options > Font sizes or Options > Player controls > Lower bar > Transport button size/spacing to set your sizes. The menu is still good if you want to precisely set them. When using this new feature, not all
font sizes will be marked/checked in the menu due to +1 and -1 increments.

Here is the commit message:

• Implemented mouse wheel interface scaling

  • Activates when pressing Ctrl + mouse wheel up to enlarge, and Ctrl + mouse wheel down to shrink.
  • Resets to default size when pressing Alt + mouse wheel in any direction.
  • Available for the mouse in the top menu area.
  • Available for the mouse in the lower bar area.
  • Available for the mouse in the lower bar transport buttons area:
    • Additional Shift + mouse wheel for lower bar button spacing,
      and Shift + Alt + mouse wheel to reset to default spacing.
      Otherwise, Ctrl + mouse wheel to enlarge or shrink the buttons.
  • Available for the mouse in the Playlist panel.
  • Available for the mouse in Details metadata grid sections:
    • Artist, title, album, tag name, and tag value areas.
  • Available for the mouse in the Library panel.
  • Available for the mouse in the Biography panel.
  • Available for the mouse in the Lyrics panel.

• Improved and fixed a cosmetic issue with the top menu font size when the font size
  was very large and the player width was at its minimum in Artwork and Compact layouts.

  Available now in the master:
  https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

  ---

  I am back now to work on the website and its documentation.

  -Tom

[TT-ReBORN]

@regorxxx,

this was an issue in the past and present, users with a very large playlist ( say 50K tracks )
takes a very long time to process and load the playlist. I have debugged the issue and found out
that the EvalWithMetadbs method is the bottleneck.

I am using it for the playlist header creation here:

	static prepare_initialization_data(rows_to_process, rows_metadb) {
		let query = PlaylistHeader.grouping_handler.get_query();
		if (plSet.show_disc_header && query && PlaylistHeader.grouping_handler.show_disc()) {
			query = query.replace(/%discnumber%|%totaldiscs%|%subtitle%/g, '');
		}

		// Measure time for fb.TitleFormat
		const startTimeTF = Date.now();
		const tfo = fb.TitleFormat(query || ''); // Workaround a bug, because of which '' is sometimes treated as null
		const endTimeTF = Date.now();
		const elapsedTimeTF = endTimeTF - startTimeTF;
		console.log('Elapsed Time for fb.TitleFormat:', elapsedTimeTF, 'milliseconds');

		// Measure time for tfo.EvalWithMetadbs
		const startTimeEM = Date.now();
		const rows_data = tfo.EvalWithMetadbs(rows_metadb);
		const endTimeEM = Date.now();
		const elapsedTimeEM = endTimeEM - startTimeEM;
		console.log('Elapsed Time for EvalWithMetadbs:', elapsedTimeEM, 'milliseconds');

		// Conditionally measure time for preparing disc data
		let prepared_disc_data = [];
		if (plSet.show_disc_header) {
			const startTimePD = Date.now();
			prepared_disc_data = PlaylistDiscHeader.prepare_initialization_data(rows_to_process, rows_metadb);
			const endTimePD = Date.now();
			const elapsedTimePD = endTimePD - startTimePD;
			console.log('Elapsed Time for preparing disc data:', elapsedTimePD, 'milliseconds');
		}

		const zippedData = Zip(rows_to_process, rows_data);

		return [zippedData, prepared_disc_data];
	}

With 35K tracks in one playlist it takes about 6 seconds to process via EvalWithMetadbs :(
I am looking for an alternative solution.

Btw, I always thought that window.Reload() does GC on reload but that does not seem the case!?
When I reload the same playlist, it takes only 200ms for EvalWithMetadbs,
so it seems the cache is still present vs a fresh foobar exit and foobar start -> 6 seconds.

I already made some optimizations for the playlist and could squeeze additional 13% performance gain,
but now this is the last iron wall I can not overcome :(

P.S I know this is a bit late, but I never debugged it precisely what the cause was because I never had that large
playlists 😅 and didn't pay close attention, but some and then users come and report this and it is also
getting on my nerves because this is the last bottleneck in Georgia-ReBORN, orginal Georgia, CatRox and other SMP themes...

-Tom

[regorxxx]

Also the window.Reload() has confused me, I always thought Yuri stated that GC takes place on reload?

I have specific cases where this is not true at all, related to tag retrieval for extreme cases near ram limits. And no matter how many times you reload the panel, the ram is not freed. It is done, sometimes, some minutes later.

I also get that performance. When it was never processed, i.e in cache ( seems SMP manages this ), I got this slow EvalWithMetadbs performance...

As I said, I don't really think that's the only problem. On Search by distance, I check a single track against the full library with +8 tags, and tag retrieval never takes more than 1 sec (and that's the worst case). 6 secs is not normal. But I have seen this kind of behaviors on startup.

Maybe you can force caching in some way applying a simple (empty?) TF over it, and then retrieving the real tags. Makes zero sense to me, but maybe it does work.

Also, things may be different on v1.6 and v2...

[TT-ReBORN]

So yeah, EvalWithMetadbs is not the culprit as you pointed out...
After two days of intensive debugging, I found out that processing the data is indeed the bottleneck and it makes of course
sense and is the general first thought but there are some really strange things going on...
It all sounds easy but it is actually not and I was very confused during those two days. I found out that timings ( fb.CreateProfiler and Date.now) can sometimes lie or are not accurate or can not exactly pinpoint the bottleneck :( .
There are still some strange things going on I need to figure out...

In the end, batch processing is indeed the key and that was my initial thought and yours too. I have implemented some prototype batch processing methods with fixed track processing, i.e first load foobar complete then load the first 1000 tracks, then after some time load the rest as background process. Batch processing on scrolling demand sounds also nice, I need to check what's the best with the least overhead when data is being processed...

Edit: I found out that SMP's CalcTotalDuration() method is a real bottleneck on large playlists :(, i.e it should be done post-processing after initial load to prevent additional big overhead

-Tom

[regorxxx]

Great you finally found the problem.

Have never had any problems with profiling, so no idea about that. For individual tests, you can use this on a new panel. It has many pre-defined tests as well as fake data to pass to functions. You can easily add your own tests too.
https://github.com/regorxxx/Profiler-SMP

To be honest, I'm not sure why CalcTotalDuration() should give problems. I mean, you could get the same info iterating every handle and checking the length. I have found sometimes pure JS approach is simply faster, if you apply the right code logic or structures...

[TT-ReBORN]

Sorry I was not clear enough, what I meant is that CalcTotalDuration() should not be used on initial foobar startup in
some methods but rather after everything has been loaded to avoid massive overhead, i.e bad performance:

It took me a while to find the CalcTotalDuration() bottleneck and I thought wth!? Maybe because it was on_paint!?

// ! Large performance issue on foobar startup when using CalcTotalDuration()
const duration = Math.round(!grm.ui.loadingThemeComplete ? '' : metadb_list.CalcTotalDuration());
if (duration) {
    duration_text = utils.FormatDuration(duration);
}

I thought that it can't be that CalcTotalDuration() has such lousy performance,
then of course I tried vanilla js method in a for loop that already is initializing the track rows:

	_initialize_rows(playlist_items) {
		const playlist_items_array = playlist_items.Convert();
		const rows = new Array(playlist_items_array.length);
		const showHeader = plSet.show_header;
		const isOddOffset = showHeader ? 0 : 1;
		let totalDuration = 0;

		for (let i = 0; i < playlist_items_array.length; ++i) {
			const row = new PlaylistRow(this.list_x, 0, this.list_w, this.row_h, playlist_items_array[i], i, this.cur_playlist_idx);
			row.is_odd = !(i & 1) ^ isOddOffset;
			rows[i] = row;
			totalDuration += playlist_items_array[i].Length;
		}

		console.log(utils.FormatDuration(totalDuration));

		return rows;
	}

So only adding the additional totalDuration += playlist_items_array[i].Length; increment in the loop has the same crap performance like CalcTotalDuration() when using it straight on foobar startup. This cost my playlist initialization additional 4-5 seconds load on very large playlist ( of course depends on items ) :(.

As I do not know the internal SMP mechanics, CalcTotalDuration() behaves like a traditional loop with same performance.
I think this can be handled much better by SMP and should be cached beforehand by SMP. BUT it should be mentioned
that the performance is very fast when foobar has been loaded/FbMetadbHandleList has been cached. I think the internal
caching mechanics are handled by SMP and not foobar...

Also maybe write a section with tips and tricks and notice in the SMP docs for other devs that could save their time and
make life easier...

[regorxxx]

Sorry I was not clear enough, what I meant is that CalcTotalDuration() should not be used on initial foobar startup in
some methods but rather after everything has been loaded to avoid massive overhead, i.e bad performance:

Oh, yes. 100% true. It happens with many more things, which take 30 seconds at startup and 1 sec otherwise. That's why I have delayed ton of things on some of my scripts, in particular the playlist manager... because it produced slowdowns at startup for no reason.

About expecting SMP handling things better. Well, it depends. At least on my experience. For ex. queries are not cached in any way, even if the library has not changed and there have been no metadata updates. So everytime SMP process a query, it performs all steps. There are many other cases where explicit caching or better logic reduce the processing time.

About your particular use case, you could cache the last total duration value before closing foobar (well since shutdown callback doesn't allow to save properties, just use a config file or save periodically the value to properties). And reuse at startup. Then calculate the real value later. So at least you have something as placeholder... (and it's expected the startup playlist to be the same than the one at shutdown).

[Meisfuture]

Hi Tom, I've been playing some songs and I often find that the wrong lyrics are given, I don't know what's wrong, I've installed the ESLyrics with OpenLyrics plugin in other players and play testing it gives the correct lyrics correctly recognized the first time. I am attaching a song for you to test.

Forever and a Day.zip

[mauriva]

I, too, have noticed several strange behaviors of the lyrics component.

1. It also happens to me several times that the lyrics shown are from a different song or are not in sync with the song being played. Often I just select from the "Lyrics options menu - Delete Lyrics" and then the correct lyrics are retrieved.

2. If I go to "Lyrics options menu - Lyrics Search" a window with lyrics results from different sources are shown, but it seems to me that there is no possibility to replace the currently displayed lyrics with one from the list (double-clicking has no effect).

3. If a unsynched lyric is found, I would like with the mouse wheel I can scroll the text at will, while instead the scroll is only set to adjust the offset. I did not understand if it is possible to change the settings in any way to change the mouse behavior.

[TT-ReBORN]

This is not a Georgia-ReBORN issue. It is just the automatic search from ESLyric that is searching and fetching lyrics from the sources in the order specified here: Preferences > Tools > ESLyric > Lyric Sources. If you didn't change the order, it is already good, imo. But you can try different orders if you want to. You can maybe also try Preferences > Tools > ESLyric > Lyric Option > Minimal match confidence set to max ( never tried it ).

Some sources for "certain" tracks do have bad results, but there is nothing you can do about it other than to manually change it via
right click in Lyrics panel > Lyric options menu > Next lyrics or Lyrics search ( where you can select and see the lyric sources ).

Of course your tracks should have artist/album artist, title and album in the metadata correctly tagged.

-Tom

[Meisfuture]

Thanks, Tom, the settings as you say did solve the problem.

[mauriva]

Thanks to the responses. Points 1 and 2 are solved, but on point 3 (the use of the mouse wheel) is there any indication? I think it is due to the text component and not the theme, but I ask here anyway, since I feel among “friends”.

[TT-ReBORN]

@mauriva,

I'm not sure what you exactly mean?
From my understanding, you just want to scroll faster through unsynced lyrics?

You can try it yourself to see if it is what you want:
Open this file foobar2000\profile\georgia-reborn\scripts\Base\gr-lyrics.js and go to line ~700 on_mouse_wheel(step) {
it is nearly at the buttom of the script. Now change this line:
this.userOffset += 500 * -step;
to
this.userOffset += (utils.IsKeyPressed(VK_SHIFT) ? 5000 : 500) * -step;
Save the file and restart foobar.

Now if you hold the Shift key while mouse wheel scrolling, it will scroll much faster, i.e every 5 seconds ( 5000ms ) instead of every half second ( 500ms ). And with normal mouse wheel scroll ( not holding the Shift key ), it will scroll every half second as usual.

-Tom

[acstrp]

Not getting a thumbnail generated from this album cover image: https://ptpimg.me/4pmq54.jpg

I think I've encountered this before, is 3000x3000 not supported?

[TT-ReBORN]

There is no issue when this image is in album folder:

Or when it is embedded:

---

This happens if your hard drive was in sleep mode while it tried to fetch the playlist header thumb nail, i.e on startup or while scrolling.
When this happens, just refresh the playlist -> right click for context menu > Refresh playlist. Or just press the F5 key.

I'll add this to the FAQ.

-Tom

[acstrp]

That wasn't my issue, but I did figure it out.

It's a 2 disc version of the album with disc 1 and disc 2 in subfolders - I only had cover.jpg in the root album folder

\cover.jpg
\Disc 1
\Disc 2

Once I copied the artwork into the disc 1 folder, the thumbnail was generated. Would have preferred to keep it in the root album directory though.

Semi-related - I asked a long time ago, but do you think there is any way to use a customthumbnail for a boxset but then unique covers for each disc?

[TT-ReBORN]

So you want to have a cover.jpg/png in the root of a multi-cd album that acts as a boxset cover and will be displayed as the
playlist thumbnail and then in the sub-folders ( CD 1, CD 2 etc ) their own cover.jpg/png?

Just add the relative root folder path in foobar's Preferences >Display > Album art > Front cover tab: ..\cover.*

Now the root cover image will be displayed as the playlist thumbnail, and CD 1/CD 2 have their own cover image in their folders
that will be displayed as the large album art on the left side.

-Tom

[acstrp]

Thank you, that works perfectly. I feel like I should have adjusted that option on my own..

[Meisfuture]

Tom, when I'm under the details screen, if I use scroll to find an album, a residual block appears at the top, sometime it disappears on its own, sometimes it stays there for a long time, I don't know what's the reason for that. As shown in the picture:

also some JEPG format covers don't seem to show up properly on the album, that's nothing, I changed it to JPG and it works. Position as shown:

[TT-ReBORN]

Ok I could fix the first issue, was a regression from the rewrite, but I do not understand the second issue.
Can you tell me more? Also can you please post the problematic image?

[Meisfuture]

Regarding the JPEG's not displaying, I just tested it and it's displaying fine again, I did come across it a few times but I converted it to JPG, I'll send you the relevant image when I come across it later.

[TT-ReBORN]

Guys, I have great news for you all.

Georgia-ReBORN uses the Playlist script that is also present in the original Georgia, original CaTRoX, CaTRoX_QWR and NekoRox.

The other themes are using old Playlist script code and I have rewritten the Playlist with more modern code and more features and fixes over the years. But there always was the performance issue when using a very large playlist, i.e starting from 20.000 tracks or much much more... The foobar startup is very slow and also when switching from a small playlist to a large playlist or to another large playlist.
That is because the Playlist script processed all tracks at ONCE which is a performance issue on very large playlists.

Now I have implemented a somewhat intelligent dynamic batch processor with caching that first loads 1000 tracks at once and then process the remaining tracks ( in batches ) in background until it has finished. This batch processing feature solves the performance issue when loading large playlist and it dramatically decreases foobar startup and playlist switching loading times.

I have done some test with various playlist size tracks ( 1000, 5000, 10000, 25000, 50000, 75000, 100000, 150000, 200000, 250000 )
and I think it works great! Of course the more tracks a playlist has, the longer the batch processing will take time to finish, this also depends of course on your CPU power! After each batch has been processed it will lazy load each batch with its tracks at the end of the playlist. Also it seems foobar 32bit ( 4GB ram limit ) with 1 million tracks can probably get into memory issues.

So guys, can you do some testing before I publish it on Github?
Just create and play with new playlist, load your entire music collection into ONE playlist and see how the performance is.
Make some test playlist with different sizes, and then switch from one playlist to another playlist etc.
Monitor if there are any bugs and if it is robust and stable. Report any issues or bugs here, thanks!

---

I recommend to make a new test portable foobar installation for this and keep your existing Georgia-ReBORN
after testing is complete. You can also then test how the performance is between your current Georgia-ReBORN
and the new playlist batch processor feature!

If you do not have the latest master version, download it first from here:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

Then download and replace it with this here:
Georgia-ReBORN-Playlist-Batch-Processor.zip ( Updated 15.05.2024 )

This was the last performance issue in Georgia-ReBORN and I hope it works well for all!
P.S You can check the batch processor performance and timings in the top menu > View > Console.

-Tom

[takaji10]

Here's my results from testing with 19106 tracks. Note that the computer is quite modern and the music is stored on an SSD :)

Just a question to echo @mauriva above, and I'm sure you have answered it elsewhere: Is there any way to do the same pre-loading in the background with the album art? I dream of a world where I can see the album covers as I quickly scroll by :)

UI Hacks: DLL-hijacking failed
UI Hacks: hooks status 0x4b8200
Components loaded in: 0:00.396272
Configuration read in: 0:00.021769
foobar2000 v2.2 preview 2024-05-13 x86 [portable]
myLibrary init
myInitStageCallback init
Columns UI detected that the UI Hacks (foo_ui_hacks) component is installed. UI Hacks interferes with normal Columns UI operation and should be uninstalled to avoid problems.

Writing C:\Users\Desktop\foobar2000\profile\georgia-reborn\configs\georgia-reborn-config.jsonc
Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-DEV by TT): initialized in 262 ms
User Interface initialized in: 0:00.560448
foo_enhanced_playcount: loaded
FFmpeg version: 6.0
Startup time : 0:01.614538
Library initialized after 0:01.614802
Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-DEV by TT): initialized in 36 ms
initMain()
in on_size() => width: 1140, height: 730
Playlist initializing history
Playlist => batch processing: 0 to 0 tracks (first batch)
Playlist => batch processed: 0 of 0 tracks (size: 0 - time: 0ms - goal: 2500ms)
Playlist => all tracks processed (0ms)
initMain()
in on_size() => width: 1140, height: 730
Georgia-ReBORN loaded in 1501ms
in on_size() => width: 2800, height: 1720
in on_size() => width: 2580, height: 1720
in on_size() => width: 2580, height: 1460
Playlist initializing history
Playlist => batch processing: 0 to 0 tracks (first batch)
Playlist => batch processed: 0 of 0 tracks (size: 0 - time: 0ms - goal: 2500ms)
Playlist => all tracks processed (0ms)
in on_size() => width: 2500, height: 1400
in on_size() => width: 1280, height: 800
Playlist initializing history
Playlist => batch processing: 0 to 0 tracks (first batch)
Playlist => batch processed: 0 of 0 tracks (size: 0 - time: 0ms - goal: 2500ms)
Playlist => all tracks processed (0ms)
Current released version of Georgia-ReBORN: v3.0-RC2
You are on the most current version of Georgia-ReBORN
Biography Server: wikipedia: : not found
on_metadb_changed(): 19106 handles, fromhook: false
Playlist added
Playlist => batch caches have been cleared.
Playlist => batch processing: 0 to 1007 tracks (first batch)
Playlist => batch processed: 1007 of 19106 tracks (size: 1007 - time: 11ms - goal: 2750ms)
Playlist => batch schedule delay: 5000 ms

Playlist => batch processing: 1007 to 2531 tracks
Playlist => batch processed: 2531 of 19106 tracks (size: 1524 - time: 11ms - goal: 3026ms)
Playlist => batch schedule delay: 500 ms

Playlist => batch processing: 2531 to 4830 tracks
Playlist => batch processed: 4830 of 19106 tracks (size: 2299 - time: 16ms - goal: 3329ms)
Playlist => batch schedule delay: 500 ms

Playlist => batch processing: 4830 to 8212 tracks
Playlist => batch processed: 8212 of 19106 tracks (size: 3382 - time: 20ms - goal: 3662ms)
Playlist => batch schedule delay: 500 ms

Playlist => batch processing: 8212 to 13275 tracks
Playlist => batch processed: 13275 of 19106 tracks (size: 5063 - time: 29ms - goal: 4029ms)
Playlist => batch schedule delay: 500 ms

Playlist => batch processing: 13275 to 19106 tracks
Playlist => batch processed: 19106 of 19106 tracks (size: 5831 - time: 37ms - goal: 4432ms)
Playlist => all tracks processed (71ms)
Playlist => batch caches have been cleared.
Playlist => batch processing: 0 to 1506 tracks
Playlist => batch processed: 1506 of 19106 tracks (size: 1506 - time: 12ms - goal: 4876ms)
Playlist => batch schedule delay: 500 ms

Playlist => batch processing: 1506 to 3767 tracks
Playlist => batch processed: 3767 of 19106 tracks (size: 2261 - time: 15ms - goal: 5000ms)
Playlist => batch schedule delay: 500 ms

Playlist => batch processing: 3767 to 7154 tracks
Playlist => batch processed: 7154 of 19106 tracks (size: 3387 - time: 22ms - goal: 5000ms)
Playlist => batch schedule delay: 500 ms

Playlist => batch processing: 7154 to 12218 tracks
Playlist => batch processed: 12218 of 19106 tracks (size: 5064 - time: 30ms - goal: 5000ms)
Playlist => batch schedule delay: 500 ms

Playlist => batch processing: 12218 to 19106 tracks
Playlist => batch processed: 19106 of 19106 tracks (size: 6888 - time: 38ms - goal: 5000ms)
Playlist => all tracks processed (67ms)

[TT-ReBORN]

@takaji10,

thank you for testing, these are incredible speeds, so fast!
Just to be sure, these speeds are on foobar startup and not when you switch to the large playlist or reload the theme!?
What is your CPU and SSD???

Does it lag when start your 19K playlist on foobar startup while it processes all batches in the background when you mouse scrolling
in the playlist?

Also if possible and available, can you do a test with a HDD ( if own an external HDD )?
Meaning music stored on a hard disk and not from a SSD, because I would like to see if it really changes the timings much
or if the speed is kinda the same. This information is crucial so we can find out if the batch processing is depending on raw CPU power or if fast read operations do also play a big factor...
I would really like to see the results in the log when processing the playlist tracks from a HDD.

About your question, immediate album art preloading was implemented since Georgia-ReBORN's inception ;-)
Activate it in top menu Options > Settings > Theme cache > Preload images in disk cache.
This feature is also activated when changing the theme performance to High Quality or Highest Quality in:
Top menu Options > Settings > Theme performance > High Quality or Highest Quality.

[takaji10]

I enabled "Preload images in disk cache" but I didn't notice a change - when I open foobar2000, in the Library view if I scroll quickly down, then I'll still see the default blank "music note" cover art until the actual album art loads. I also tried the "Highest quality" setting, and the action is the same.

The same issue in the Playlist view; scrolling down quickly just shows "LOADING" tiles for album art, until I stop at that part of the playlist, and then it loads...

I checked my album art cache and I can see that it's full of thumbnails, so they are for sure being generated. Is this the expected behaviour?

Regarding my computer specs:
Intel i7-12700KF with 32 GB of RAM
SSD is a Kingston SFYRS1000G

Regarding your question "Does it lag when start your 19K playlist on foobar startup while it processes all batches in the background when you mouse scrolling in the playlist?"
I opened the test instance that I created, immediately started playing a song, and then tried scrolling around in the playlist. There was a short lag for maybe a second where the scrolling slowed down, but it was only there for a brief moment.

Unfortunately I can't test with an external HDD so I can't help you there, sorry :/

[TT-ReBORN]

Actually the preloading does work in the Library when album art mode is being displayed.
It does load the thumbnails in the background but it does take some time until all are processed, for example
when Preload images in disk cache is on and I click on the Library, all thumbnails in the viewport are instantly displayed.
When you wait for a few seconds and scroll down, other thumbnails will also instantly display, it just takes some time to process them all...

The playlist thumbnails preloads only the first 10 or 100 ( don't know from the top of my head ), this could be drastically improved
ONLY WHEN we have Georgia-Reborn in 64-bit, that means we need Spider Monkey Panel 64-bit. With foobar 32-bit, we only have
4 GB available. If it's over this limit, it will crash. That means, if we load all in the background and the playlist is large, you will get pretty fast into memory issues. Keep in mind that 4K mode the ram usage is much higher and if you add the Library thumbnails on top of the Playlist thumbnails, the red screen will welcome you very often...

[takaji10]

Thanks for explaining it. :)

I remember hearing that the SMP creator last fall said he might be able to pick up on the project again - but I guess this hasn't happened yet...

Edit: Right after saying that, I discovered this, which I'd never seen before: TheQwertiest/foo_spider_monkey_panel#213

[TT-ReBORN]

Guys,

I want from you to know what are the first steps you do after you've installed Georgia-ReBORN?
Do you add your music to the Media Library, or do you change internal foobar settings or theme settings, i.e player size,
personal theme customization?

What do you think is the hardest to understand for NEW BEGINNERS/FOOBAR USERS
when using Georgia-ReBORN for the first time? How the Library with the Playlist works when playing from the Library?
Or what some Georgia-ReBORN option are good for? Basic controls?

I also want to know what you would like to see in the documentation and what would be the most important that should included?

Please leave your comments down below, thanks!

-Tom

[mauriva]

I confess that I make fairly basic use of foobar and the theme, so when I do a clean install I take action on a few aspects, most of which are not directly related to the Georgia-ReBORN. The main ones are:

• window resizing and repositioning
• keyboard shortcuts
• installation of components not included in foobar and Georgia and setting them up
• installation of the econders package

When I update the theme I always use the backup and restore of my configuration, which I find very usefull and very convenient.

Regarding the theme itself, I leave pretty much everything default because I like the starting look as it is.
However, I confess that when I view the theme images on Github or elsewhere, I don't know how to get certain results: the menus to work on are really full of entries and it's not easy to figure out what to set to get the desired look.
I think the documentation should first of all make this clear: illustrate the main features of the theme, the various display possibilities and how to get them from the menus.
I would start with the main things, leaving special and minor details in pages for advanced users.

Regarding the library I confess that I practically do not use it: I have my music organized in folders and when I want to listen to something I add the files or folders.
So even of the playlists I make a very basic use leaving practically everything by default (the only option I set is to display the artist if it is different from the album).
However, I think the documentation should list the main functions because that is the heart of using the player.

I don't know if I was any help, but these are the things that came to mind.

[TT-ReBORN]

Thanks for your insights and thoughts, it is always nice to read what people are thinking and what they do.

I think the documentation should first of all make this clear: illustrate the main features of the theme, the various display possibilities and how to get them from the menus.
I would start with the main things, leaving special and minor details in pages for advanced users.

Yes, this is how it will be. Introduction to the theme, basics, controls, theme options explained and advanced stuff like customization etc.

I have asked because I want to know what people would like to see in the documentation that should be in-depth explained or what new users are struggling with when using Georgia-ReBORN for the first time.

P.S Don't be shy, more feedback from other users are very welcome!

-Tom

[gnihtytterp]

Dear Tom, I normally set the font size and to be true also play around with fonts (but I always ended up leaving the default settings)
I also make some changes in the main confg, so in Details view I can see the info I need or eant
Then I play around with the themes, colours, but mostly I ended up usin the grey or black themes
Of course I choose the media library and alway my choice is the folder structure view
Yhanks a lot for your work, you're a genius

[TT-ReBORN]

@gnihtytterp,

thanks for the insights. Btw if you missed it, in the master version you can now use CTRL + mouse wheel up/down to change
font size and ALT + mouse wheel up/down to reset to default font size. You can use this for all fonts in the theme.

-Tom

[Meisfuture]

Tom, I tested a lot of 64-bit Component, according to my own habits and needs, in fobar2000 64-bit Default User Interface DIY a simple interface, used to 64-bit smooth, now rarely use 32-bit, as far as possible as far as I am concerned, as simple as possible, overly complex functionality for me to speak of a disaster.

Export theme.zip

[TT-ReBORN]

I'll take a look when I have some free time what you have created =)

[mauriva]

I think there is a small bug inherent in the tooltip display of the full track title.
As you can see from the image I get on several occasions that the tooltip is visible even when the mouse pointer is no longer positioned on the track in the playlist.
I don't know precisely how to reproduce this, but I just move the cursor randomly either to the top or to the bottom of the playlist.

[TT-ReBORN]

Yea I will improve this, happens if you move your mouse too fast away.

Edit: Should be now fixed in the master.

[mauriva]

I report a small thing that is not a bug but that I don't like at all.
By default the scrollbar in the playlist is hidden: it appears only if I hover my mouse cursor over the right margin of the playlist.
I like this behavior because it allows the track list to normally have more space.
What I don't like is that when the scrollbar appears, the track list undergoes a shift to the left (as seen in the attached image).
This is visually annoying (at least to me!) and also happens in several circumstances where you don't actually intend to use the scrollbar, but are just moving the mouse.
Would it be possible to display the scrollbar without moving the track list (even partially overlapping it)?

[TT-ReBORN]

The first screenshot seems like a cosmetic bug, that is actually not how it should look like but should always adjust
like your second screenshot. After years of developing Georgia-ReBORN, I have never encountered this issue...

Can you tell me what desktop resolution you are using, and what display res mode in Georgia-ReBORN?
Also did you change the Playlist font size or do you use the default one?

[acstrp]

Currently 2560x1440 desktop resolution, player size is normal, reborn display is set to HD instead of QHD.

It's probably a 50/50 shot whether it shifts over like the second screenshot or stays like the first. I've seen it before but it seems to happen more frequently since the rewrite - just tried it in an old version from last year and it only happened maybe 1 out of 8 times.

All I am doing is putting the mouse cursor on the location of the scroll bar then moving a little to the left and then back to the right where the scrollbar pops up, repeat as necessary.

edit: if you start pulling the scrollbar it does indent/move the text to the left like you expect

[fwn0]

I am not at home right now, but can you test this for me?
Open your foobar2000\profile\georgia-reborn\scripts\playlist\scripts\pl-list.js
Then go to line ~275 to this method:

	update_scrollbar() {
		const total_height_in_rows = this.cnt.calculate_total_h_in_rows();

		if (total_height_in_rows <= this.rows_to_draw_precise) {
			this.is_scrollbar_available = false;
			plSet.scrollbar_pos = 0;
			this._on_scrollbar_visibility_change(false);
		}
		else if (this.scrollbar) {
			this.scrollbar.set_window_param(this.rows_to_draw_precise, total_height_in_rows);
			this.scrollbar.scroll_to(plSet.scrollbar_pos, true);

			const invalidPos = (plSet.scrollbar_pos || this.scrollbar.scroll) > this.scrollbar.scrollable_lines; // Prevent scroll crash
			plSet.scrollbar_pos = invalidPos ? 0 : this.scrollbar.scroll;

			this.is_scrollbar_available = true;
			this._on_scrollbar_visibility_change(plSet.show_scrollbar);
		}
	}

Just add this one line at the end:
window.RepaintRect(this.x, this.y, this.w, this.h);

like this:

	update_scrollbar() {
		const total_height_in_rows = this.cnt.calculate_total_h_in_rows();

		if (total_height_in_rows <= this.rows_to_draw_precise) {
			this.is_scrollbar_available = false;
			plSet.scrollbar_pos = 0;
			this._on_scrollbar_visibility_change(false);
		}
		else if (this.scrollbar) {
			this.scrollbar.set_window_param(this.rows_to_draw_precise, total_height_in_rows);
			this.scrollbar.scroll_to(plSet.scrollbar_pos, true);

			const invalidPos = (plSet.scrollbar_pos || this.scrollbar.scroll) > this.scrollbar.scrollable_lines; // Prevent scroll crash
			plSet.scrollbar_pos = invalidPos ? 0 : this.scrollbar.scroll;

			this.is_scrollbar_available = true;
			this._on_scrollbar_visibility_change(plSet.show_scrollbar);
		}
		window.RepaintRect(this.x, this.y, this.w, this.h); // Add this here
	}

It is very possible due to lag that it does not refresh it fast enough and this issue could occur...
Please report back if this works for you, if not, I will take a look in a couple of days.

[acstrp]

Just had a chance to try -- that indeed fixes it.

[TT-ReBORN]

Thanks for testing! Glad this blind tip worked out, I will upload the fix.

[acstrp]

Is there a way to monitor foobar component cpu use?

I've noticed after foobar has been opened a couple days I will come back and it is using 2 to 4% cpu with no song playing. Normally its 0% or .1% at idle.

No changes to the library and no auto downloads are currently enabled. Left stock foobar without ReBORN running in the background for the last few days and it isn't having the same issue so I assume it is a plugin used with ReBORN. Just not sure how to see the granular cpu usage.

[TT-ReBORN]

Unfortunately there is no way because foobar with its user-components are running just as one process.

A week ago or so I have implemented an internal CPU tracker that is more accurate than the Windows task manager.
You can activate the performance overlay via top menu > Options > Settings > Developer tools
Once Developer tools are enabled navigate again to top menu > Options > Developer tools > Enable debug performance overlay.

The CPU tracker in the overlay measures the CPU for one CPU core because JavaScript is single threaded, this applies for all
JavaScript files ( themes, scripts ) in foobar. The CPU tracker in your situation still won't help much...

For testing, I would make a new extra portable foobar installation and disable/remove all optional user-components,
see here: #102 .
Once done, you can keep it running parallel with your foobar ( the one you are currently using ) for a couple of days
and see if it helps.

-Tom

[acstrp]

OK thanks for the info. Figured that was the case about individual component cpu usage - thought I would check with you (er I mean the expert) to confirm.

Still at 0% usage after ~24 hours. I have no optional user components right now, will keep an eye on it and see if I can figure anything out.

[acstrp]

Quick update on this.

No matter what I changed I kept coming back hours later and finding foobar using 4-5% even 7-8% CPU when the program should be idle.

I've tried a lot of different things over the last week.

The last thing I did was disable "Automatically search when playback starts" in the ESLyric\Lyric Option preferences menu.

With ESLyric auto search disabled, and then never looking at lyrics, I haven't had a single issue (yet).

At idle, foobar is using 0% cpu to .2% cpu again. Playback CPU usage seems lower. I have yet to come back and find foobar using any CPU cycles that it shouldn't.

Please note that I haven't pre-fetched any lyrics for my library.

Will keep an eye on this for a few more days to see if I get any CPU usage I shouldn't.

[TT-ReBORN]

@acstrp, thanks for reporting.

It is possible that when using "Automatically search when playback starts" it does not clear all threads/processes during a long playback session or a ( or some ) ESLyric source script/s could have issues.

Can you please debug it to find out if the issues lies in the ESLyric source scripts and which script/s are making this issue?
Enable again "Automatically search when playback starts" and start to disable half of the ESLyric scripts and see if it works:

If you remember which songs you've played, you should also play these song/songs where you think this issue could happen.

If the issue still persist, disable the next half of the remaining ones and so on to pinpoint which script/s is/are at fault.
If the scripts are OK, we need to report it to ttsping. Btw, I have read that he is currently rewriting the ESLyric code.

-TT

[acstrp]

5 days of uptime and foobar is still at 0% cpu use on idle (and 260MB RAM usage, not that it matters since there is no memory leak for this issue) so I can safely say that ESLyric is the cause of the constant CPU usage I have been experiencing.

I will re-enable it and start working through the lyric sources, but the issue often takes a couple days to appear so it might not be a fast process, no idea what tracks are causing the issue.

I may be finding more ESLyric issues since I am constantly introducing new albums (ReBORN motivated me to fix up all my files, they were a mess, so every day I try to clean the tags on some albums and add good coverart and move them into my foobar library).

[Fizbin99]

I would say mission accomplished. It's also not crashing with your latest bio callbacks that I missed.

Edit... The 'part 2' fix may not work with other themes. It does not work as well as I thought it did with my Darkone tweak theme. (Yes, with the modded 'georgia reborn code' removed). I'm not sure why there would be a difference, but it definitely seems to work 100% with G.R.

[TT-ReBORN]

This is my current code, keep in mind I have modified the names to WilB's original naming conventions.
I am just using additional prefixes bio or Bio and some other things to prevent conflict issues,
because Georgia-ReBORN is not isolated and shares all its code in one global space, i.e one Spider Monkey Panel
only.

You only need to paste these in the original biography scripts:

Original biography callbacks.js:

• Add allMusicReq.abortRequest(); after the server.

function on_script_unload() {
	if ($.server) {
		window.NotifyOthers(`bio_scriptUnload${ppt.serverName}`, 0);
		timer.clear(timer.img);
	}
	allMusicReq.abortRequest();
	but.on_script_unload();
	txt.deactivateTooltip();
}

Original biography allmusic.js:

• Remove function onStateChange and function send and replace it with the class,
  don't forgot to add the instance allMusicReq right after the class.
• Replace all 10 send({ with allMusicReq.send({

class RequestAllmusic {
	constructor() {
		this.request = null;
		this.timer = null;
		this.checkResponse = null;
	}

	abortRequest() {
		if (!this.request) return;
		clearTimeout(this.timer);
		clearInterval(this.checkResponse);
		this.request.Abort();
		this.request = null;
		this.timer = null;
		this.checkResponse = null;
	}

	onStateChange(resolve, reject, func = null) { // credit regorxxx
		if (this.request !== null) {
			if (this.request.Status === 200) {
				return func ? func(this.request.ResponseText, this.request) : resolve(this.request.ResponseText);
			} else if (!func) {
				return reject(this.request.ResponseText);
			}
		} else if (!func) {
			return reject({ status: 408, responseText: 'Request Timeout' });
		}
		return null;
	}

	send({ method = 'GET', URL, body = void (0), func = null, requestHeader = [], bypassCache = false, timeout = 5000 }) { // credit regorxxx
		this.abortRequest();

		return new Promise((resolve, reject) => {
			// https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest#bypassing_the_cache
			// Add ('&' + new Date().getTime()) to URLS to avoid caching
			const fullUrl = URL + (bypassCache ? (/\?/.test(URL) ? '&' : '?') + new Date().getTime() : '');
			this.request = new ActiveXObject('WinHttp.WinHttpRequest.5.1');
			this.request.Open(method, fullUrl, true);

			requestHeader.forEach(pair => {
				if (!pair[0] || !pair[1]) {
					console.log(`HTTP Headers missing: ${pair}`);
					return;
				}
				this.request.SetRequestHeader(...pair);
			});

			if (bypassCache) {
				this.request.SetRequestHeader('Cache-Control', 'private');
				this.request.SetRequestHeader('Pragma', 'no-cache');
				this.request.SetRequestHeader('Cache', 'no-store');
				this.request.SetRequestHeader('If-Modified-Since', 'Sat, 1 Jan 2000 00:00:00 GMT');
			}

			this.request.SetTimeouts(timeout, timeout, timeout, timeout);
			this.request.Send(method === 'POST' ? body : void (0));

			this.timer = setTimeout(() => {
				clearInterval(this.checkResponse);
				try {
					this.request.WaitForResponse(-1);
					this.onStateChange(resolve, reject, func);
				} catch (e) {
					let status = 400;
					if (e.message.indexOf('0x80072ee7') !== -1) {
						status = 400;
					} else if (e.message.indexOf('0x80072ee2') !== -1) {
						status = 408;
					} else if (e.message.indexOf('0x8000000a') !== -1) {
						status = 408;
					}
					this.abortRequest();
					reject({ status, responseText: e.message });
				}
			}, timeout);

			this.checkResponse = setInterval(() => {
				let response;
				try {
					response = this.request.Status && this.request.ResponseText;
				} catch (e) {}
				if (!response) return;
				this.onStateChange(resolve, reject, func);
			}, 30);
		});
	}
}

/**
 * The instance of `RequestAllmusic` class for biography AllMusic request operations.
 * @typedef {RequestAllmusic}
 * @global
 */
const allMusicReq = new RequestAllmusic();

[Fizbin99]

Oh boy. Now I've found a new problem. With the latest fix, Allmusic isn't loading most of the time. If you right click and select Load, it's usually greyed out. If I replace the fixed bio-allmusic.js with the one from the latest master zip file, it always loads.

Does this happen to you as well?

[TT-ReBORN]

No, everything works OK as of the latest master from the last commit 1 hour ago:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

It is only grayed out because it hasn't fetched/downloaded the allmusic stuff, but if fetching is done or it is already cached,
it is available in the menu and everything works fine.

The code for the original biography is also the final that includes all changes up til now from the master:
#74 (reply in thread)

[Fizbin99]

New link... https://youtu.be/AuTjFn5cZMU

The first round of testing is with the latest allmusic.js commit file. As you can see Allmusic only loads once, on the first selected artist. The 2nd round of testing is with allmusic.js from the latest master zip file. With one exception, Allmusic loads every time.

[TT-ReBORN]

@Fizbin99, you're right. This was not working all the time, because the method was too aggressive.
We need to clear the interval and connection at the beginning when send is called.

The latest master should now work, please replace all script files:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

I have also updated the code for the original biography script above; the current state of code as the same as the master:
#74 (reply in thread)

I have tested it a little bit and it should not crash foobar and it should always fetch AllMusic correctly and clear the response interval after fetching. Hopefully all should be working now, fingers crossed...

[Fizbin99]

Yup, everything is working perfectly! Thanks for including the script for the original Biography as well.

[Fizbin99]

I discovered another bug in Biography. The lyrics will not work when there is a "/" in the title of the artist. IE: AC/DC. I was able to get ChatGPT to fix it, but I don't know if it's a proper fix or just a band-aid fix. I also do not know if other symbols besides "/" are a problem, nor do I know if the fix is just for the "/" symbol.

The ChatGPT fix is in bio-text.js, lines 1008 to 1011

const a = $Bio.tfEscape(bio.name.artist(!v.lyrics ? bio.panel.id.focus : false, !!v.lyrics).replace(/\//g, '_'));
const aa = $Bio.tfEscape(bio.name.albumArtist(!v.lyrics ? bio.panel.id.focus : false, !!v.lyrics).replace(/\//g, '_'));
const l = $Bio.tfEscape(bio.name.album(!v.lyrics ? bio.panel.id.focus : false, !!v.lyrics).replace(/\//g, '_'));
const tr = $Bio.tfEscape(bio.name.title(!v.lyrics ? bio.panel.id.focus : false, !!v.lyrics).replace(/\//g, '_'));

[TT-ReBORN]

Seems WilB forgot to clean up filenames, I did that for my lyrics panel.

Your regexp only replaces / to _ in artist, albumArtist, album and title.
But we need to replace all reserved characters <>:"/\\|?* in filenames and make it also more elegant and efficient
with this helper I wrote:

		const cleanFileName = (path) => { // WilB, move this helper to helpers.js for common usage!?
			const stripReservedChars = (filename) => filename.replace(/[<>:"/\\|?*]+/g, '_');
			const lastSlash = path.lastIndexOf('\\');
			const dirPath = path.substring(0, lastSlash + 1);
			const fileName = path.substring(lastSlash + 1);
			const safeFileName = stripReservedChars(fileName);
			return dirPath + safeFileName;
		};

Then we can use it like this:

	findFile(v, n) {
		const type = /_\.(lrc|txt)$/.test(v.pth) ? 0 : /\.(lrc|txt)$/.test(v.pth) ? 1 : 2;
		let pth = '';
		let item = n == 'bio' ? v.pth.replace(/%BIO_ARTIST%|%BIO_ALBUMARTIST%/gi, '%BIO_ARTIST%') : v.pth.replace(/%BIO_ALBUMARTIST%|%BIO_ARTIST%/gi, '%BIO_ALBUMARTIST%');

		const a = $Bio.tfEscape(bio.name.artist(!v.lyrics ? bio.panel.id.focus : false, !!v.lyrics));
		const aa = $Bio.tfEscape(bio.name.albumArtist(!v.lyrics ? bio.panel.id.focus : false, !!v.lyrics));
		const l = $Bio.tfEscape(bio.name.album(!v.lyrics ? bio.panel.id.focus : false, !!v.lyrics));
		const tr = $Bio.tfEscape(bio.name.title(!v.lyrics ? bio.panel.id.focus : false, !!v.lyrics));
		item = item // substitue bio var + check advanced radio stream parser (tfBio & tfRev do lookUps not parser)
			.replace(/((\$if|\$and|\$or|\$not|\$xor)(|\d)\(|\[)[^$%]*%bio_artist%/gi, a ? '$&#@!%path%#@!' : '$&').replace(/%bio_artist%/gi, a)
			.replace(/((\$if|\$and|\$or|\$not|\$xor)(|\d)\(|\[)[^$%]*%bio_albumartist%/gi, aa ? '$&#@!%path%#@!' : '$&').replace(/%bio_albumartist%/gi, aa)
			.replace(/((\$if|\$and|\$or|\$not|\$xor)(|\d)\(|\[)[^$%]*%bio_album%/gi, l ? '$&#@!%path%#@!' : '$&').replace(/%bio_album%/gi, l)
			.replace(/((\$if|\$and|\$or|\$not|\$xor)(|\d)\(|\[)[^$%]*%bio_title%/gi, tr ? '$&#@!%path%#@!' : '$&').replace(/%bio_title%/gi, tr);

		const cleanFileName = (path) => { // WilB, move this helper to helpers.js for common usage!?
			const stripReservedChars = (filename) => filename.replace(/[<>:"/\\|?*]+/g, '_');
			const lastSlash = path.lastIndexOf('\\');
			const dirPath = path.substring(0, lastSlash + 1);
			const fileName = path.substring(lastSlash + 1);
			const safeFileName = stripReservedChars(fileName);
			return dirPath + safeFileName;
		};
		item = cleanFileName(item);

		switch (type) {
			case 0: pth = item.replace(/_\.(lrc|txt)$/, '.$1'); break;
			case 1: pth = item.replace(/\.(lrc|txt)$/, '_.$1'); break;
		}
		const pths = !v.lyrics ? [item] : [item, pth];
		return pths.some(w => {
			const wildCard = /[*?]/.test(w);
			if (!wildCard) {
				this[n].readerItem = bio.panel.cleanPth(w, !v.lyrics ? bio.panel.id.focus : false, !v.lyrics ? '' : 'lyr').slice(0, -1).replace(/#@!.*?#@!/g, '');
			} else {
				let p = bio.panel.cleanPth(w.replace(/\*/g, '@!@').replace(/\?/g, '!@!'), !v.lyrics ? bioSet.focus : false, !v.lyrics ? '' : 'lyr').slice(0, -1);
				p = p.replace(/@!@/g, '*').replace(/!@!/g, '?').replace(/#@!.*?#@!/g, '');
				const arr = utils.Glob(p);
				if (!arr.length) return false;
				this[n].readerItem = arr[0];
			}
			return $Bio.file(this[n].readerItem);
		});
	}

I have left a comment for WilB recommending to move this helper to bio-helpers.js, if he wants to.
Then you can use only this oneliner for cleanup: item = cleanFileName(item);.