Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with @ngrx/router #96

Open
Airblader opened this issue Feb 21, 2019 · 2 comments
Open

Integration with @ngrx/router #96

Airblader opened this issue Feb 21, 2019 · 2 comments
Labels
Comp: Core Core functionality of ngqp Priority: Low This is nice-to-have, but doesn't really affect users directly Status: Discussion We're not yet sure whether or how to implement this feature Type: Feature If you want to add something that doesn't exist yet

Comments

@Airblader
Copy link
Collaborator

What's your idea?

Let's investigate if it would make sense to integrate with @ngrx/router. A possible solution could be using our RouterAdapter infrastructure to pull state from the store and push state by dispatching actions. This would probably be done as a separate package (@ngqp/ngrx-router-adapter).

I have no experience with @ngrx/router, so this is highly theoretical and needs to be checked for feasability.

@Airblader Airblader added Type: Feature If you want to add something that doesn't exist yet Status: Discussion We're not yet sure whether or how to implement this feature Comp: Core Core functionality of ngqp Priority: Low This is nice-to-have, but doesn't really affect users directly labels Feb 21, 2019
@dev054
Copy link

dev054 commented Aug 10, 2020

Hello @Airblader, do you have some news for this?

@Airblader
Copy link
Collaborator Author

I haven't worked with ngrx router yet so unfortunately no, there's no progress. I still think the idea of using a custom router adapter in ngqp might work*, and is something that can probably be prototyped fairly easily to see whether it's feasible.

*) The API here is still a bit opionated towards Angular router by using its types, but that should be easy to work around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp: Core Core functionality of ngqp Priority: Low This is nice-to-have, but doesn't really affect users directly Status: Discussion We're not yet sure whether or how to implement this feature Type: Feature If you want to add something that doesn't exist yet
Projects
None yet
Development

No branches or pull requests

2 participants