Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video between card and add-on #63

Closed
TECH7Fox opened this issue Jan 21, 2022 · 7 comments
Closed

Fix video between card and add-on #63

TECH7Fox opened this issue Jan 21, 2022 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@TECH7Fox
Copy link
Owner

Got this when trying to call with HA-SIP 0.2.6 with video enabled on both card and add-on.

[Jan 21 22:21:51]   == Using SIP VIDEO CoS mark 6
[Jan 21 22:21:51]   == Using SIP RTP CoS mark 5
[Jan 21 22:21:51] WARNING[515][C-00000002]: chan_sip.c:10921 process_sdp: Failed to receive SDP offer/answer with required SRTP crypto attributes for audio

Video enabled on add-on and disabled on card does work.

Got a 488 not acceptable here from the card when video is enabled for card en disabled for add-on, as expected.
@TECH7Fox TECH7Fox added bug Something isn't working help wanted Extra attention is needed labels Jan 21, 2022
@TECH7Fox TECH7Fox mentioned this issue Jan 21, 2022
Closed
@thundergreen
Copy link
Contributor

i confirm! video enabled in asterisk but disabled in card works

@TECH7Fox TECH7Fox mentioned this issue Jan 23, 2022
Merged
@TECH7Fox
Copy link
Owner Author

Fixed with HA-SIP 0.3.0.

@felipecrs
Copy link
Collaborator

Should we enable video support by default now?

@felipecrs felipecrs mentioned this issue Jan 31, 2022
Merged
@TECH7Fox
Copy link
Owner Author

Should we enable video support by default now?

Yes, good idea.

@pergolafabio
Copy link
Contributor

does it now also work on companion app?

@TECH7Fox
Copy link
Owner Author

Haven’t tried that, but don’t think it has access to the camera right? And it still needs to support the codecs.

onsip/SIP.js#31

@pergolafabio
Copy link
Contributor

yeah; but the problem was the incoming call
see :

https://github.com/TECH7Fox/Asterisk-integration/issues/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thundergreen @felipecrs @TECH7Fox @pergolafabio