Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DID resolver contentMetadata to return {} #516

Open
kirahsapong opened this issue May 7, 2024 · 1 comment
Open

Update DID resolver contentMetadata to return {} #516

kirahsapong opened this issue May 7, 2024 · 1 comment

Comments

@kirahsapong
Copy link
Contributor

From @AlexHsieh in this comment:

Also at reading web5-js, found out that this line

contentMetadata : didResolutionMetadata

should be

contentMetadata : didDocumentMetadata

Someone might help check ? thanks

@kirahsapong kirahsapong changed the title Update DID resolver contentMetadata to return didDocumentMetadata Update DID resolver contentMetadata to return {} May 22, 2024
@kirahsapong
Copy link
Contributor Author

kirahsapong commented May 22, 2024

Update on the above: contentMetadata should be an empty metadata structure {} per the spec:

contentMetadata
If the dereferencing is successful, this MUST be a metadata structure, but the structure MAY be empty.
This structure contains metadata about the contentStream. If the contentStream is a DID document, this MUST be a didDocumentMetadata structure as described in DID Resolution.
If the dereferencing is unsuccessful, this output MUST be an empty metadata structure.

Good catch @frankhinek and @AlexHsieh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant