You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
create
Design: from status list lifecycle management and dev experience standpoint, I doubt one would frequently create a status initially with credentials already revoked. It would be more useful if:
There is an option/method that takes in an existing status list to be operated on.
ie. Revoke a VC from an existing status list. This would be the main line scenario of status list usage. I'd suggest to have create() create an empty list, and perhaps revoke() that does the bit operation on an existing list.
It would be nice to support toggle from 1 to 0 also.
ie. Reactivate a suspension of VC.
(To be clear, this one is completely an optional ask, please ignore unless super low hanging fruit)
validateCredentialInStatusList
Design: this is probably bad naming of the method, or bad ChatGPT documentation generation 😆 :
When the value is 1 in the given index position, it does not mean the credential is "in the status list" as the method name and documentation states, it can be a valid index even if the value is 0. So we ought to rename the method to something like isCredentialRevoked(), though I generally prefer having method checking for the happy case, in which case something like validateCredentialStatus() and flip the logic.
The text was updated successfully, but these errors were encountered:
From @thehenrytsai
create
Design: from status list lifecycle management and dev experience standpoint, I doubt one would frequently create a status initially with credentials already revoked. It would be more useful if:
ie. Revoke a VC from an existing status list. This would be the main line scenario of status list usage. I'd suggest to have
create()
create an empty list, and perhapsrevoke()
that does the bit operation on an existing list.ie. Reactivate a suspension of VC.
(To be clear, this one is completely an optional ask, please ignore unless super low hanging fruit)
validateCredentialInStatusList
Design: this is probably bad naming of the method, or bad ChatGPT documentation generation 😆 :
When the value is 1 in the given index position, it does not mean the credential is "in the status list" as the method name and documentation states, it can be a valid index even if the value is 0. So we ought to rename the method to something like isCredentialRevoked(), though I generally prefer having method checking for the happy case, in which case something like validateCredentialStatus() and flip the logic.
The text was updated successfully, but these errors were encountered: