Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Status List Credential API #487

Open
nitro-neal opened this issue Apr 8, 2024 · 0 comments
Open

Update Status List Credential API #487

nitro-neal opened this issue Apr 8, 2024 · 0 comments
Assignees

Comments

@nitro-neal
Copy link
Contributor

nitro-neal commented Apr 8, 2024

From @thehenrytsai

create
Design: from status list lifecycle management and dev experience standpoint, I doubt one would frequently create a status initially with credentials already revoked. It would be more useful if:

  1. There is an option/method that takes in an existing status list to be operated on.
    ie. Revoke a VC from an existing status list. This would be the main line scenario of status list usage. I'd suggest to have create() create an empty list, and perhaps revoke() that does the bit operation on an existing list.
  2. It would be nice to support toggle from 1 to 0 also.
    ie. Reactivate a suspension of VC.
    (To be clear, this one is completely an optional ask, please ignore unless super low hanging fruit)

validateCredentialInStatusList
Design: this is probably bad naming of the method, or bad ChatGPT documentation generation 😆 :

When the value is 1 in the given index position, it does not mean the credential is "in the status list" as the method name and documentation states, it can be a valid index even if the value is 0. So we ought to rename the method to something like isCredentialRevoked(), though I generally prefer having method checking for the happy case, in which case something like validateCredentialStatus() and flip the logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant